jmeter-commits mailing list archives

Author: pmouawad
Date: Sun Apr  1 19:52:39 2018
New Revision: 1828150

URL: http://svn.apache.org/viewvc?rev=1828150&view=rev
Log:
Document better
Add NOSonar for false positive

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/control/GenericController.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/control/GenericController.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/control/GenericController.java?rev=1828150&r1=1828149&r2=1828150&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/control/GenericController.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/control/GenericController.java Sun Apr  1 19:52:39
2018
@@ -71,7 +71,7 @@ public class GenericController extends A
     protected transient int current;
 
     /**
-     * TODO document this
+     * Current iteration
      */
     private transient int iterCount;
     
@@ -217,7 +217,8 @@ public class GenericController extends A
      * @return the next sampler
      * @throws NextIsNullException when the end of the list has already been reached
      */
-    protected Sampler nextIsAController(Controller controller) throws NextIsNullException
{
+    protected Sampler nextIsAController(Controller controller) 
+            throws NextIsNullException { // NOSONAR false positive , throws is required by
subclasses 
         Sampler sampler = controller.next();
         if (sampler == null) {
             currentReturnedNull(controller);
@@ -236,7 +237,8 @@ public class GenericController extends A
      * @return input element
      * @throws NextIsNullException when the end of the list has already been reached
      */
-    protected Sampler nextIsASampler(Sampler element) throws NextIsNullException {
+    protected Sampler nextIsASampler(Sampler element) 
+            throws NextIsNullException { // NOSONAR false positive , throws is required by
subclasses
         incrementCurrent();
         return element;
     }
@@ -248,7 +250,8 @@ public class GenericController extends A
      * @return null (always, for this class)
      * @throws NextIsNullException when the end of the list has already been reached
      */
-    protected Sampler nextIsNull() throws NextIsNullException {
+    protected Sampler nextIsNull() 
+            throws NextIsNullException { // NOSONAR false positive , throws is required by
subclasses
         reInitialize();
         return null;
     }
@@ -297,6 +300,7 @@ public class GenericController extends A
      *             when the list has been completed already
      */
     protected void setCurrentElement(TestElement currentElement) throws NextIsNullException
{
+        // NOOP
     }
 
     /**