jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1818559 - /jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
Date Fri, 22 Dec 2017 11:58:16 GMT
Am 18.12.2017 um 13:46 schrieb pmouawad@apache.org:
> Author: pmouawad
> Date: Mon Dec 18 12:46:08 2017
> New Revision: 1818559
>
> URL: http://svn.apache.org/viewvc?rev=1818559&view=rev
> Log:
> Javadocs cleanup by Graham Russell
> This comment #355
>
> Modified:
>      jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java?rev=1818559&r1=1818558&r2=1818559&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java Mon Dec 18 12:46:08
2017
> @@ -34,28 +34,18 @@ import org.apache.jmeter.util.JMeterUtil
>    * The class is not thread-safe - it is only intended for use within a single thread.
>    */
>   public class JMeterContext {
> -    private JMeterVariables variables;
>   
> +    private JMeterVariables variables;
>       private SampleResult previousResult;
> -
>       private Sampler currentSampler;
> -
>       private Sampler previousSampler;
> -
>       private boolean samplingStarted;
> -
>       private StandardJMeterEngine engine;
> -
>       private JMeterThread thread;
> -
>       private AbstractThreadGroup threadGroup;
> -
>       private int threadNum;
> -
>       private boolean restartNextLoop = false;
> -
>       private ConcurrentHashMap<String, Object> samplerContext = new ConcurrentHashMap<>(5);
> -
>       private boolean recording;
>   
>       JMeterContext() {
> @@ -155,10 +145,7 @@ public class JMeterContext {
>       }
>   
>       /**
> -     * Sets the threadNum.
>        * Internally called by JMeter, never call it directly
> -     * @param threadNum
> -     *            the threadNum to set
JavaDoc comments must document the parameters for the method - at least 
in our setup.
So deleting of the @param paragraph will lead to warnings on "ant api-docs".

These warnings can be seen in the current builds.

This should be reverted in my eyes.
  Felix

>        */
>       public void setThreadNum(int threadNum) {
>           this.threadNum = threadNum;
> @@ -170,7 +157,6 @@ public class JMeterContext {
>       
>       /**
>        * Internally called by JMeter, never call it directly
> -     * @param thread {@link JMeterThread}
>        */
>       public void setThread(JMeterThread thread) {
>           this.thread = thread;
> @@ -182,7 +168,6 @@ public class JMeterContext {
>   
>       /**
>        * Internally called by JMeter, never call it directly
> -     * @param threadgrp {@link AbstractThreadGroup}
>        */
>       public void setThreadGroup(AbstractThreadGroup threadgrp) {
>           this.threadGroup = threadgrp;
> @@ -194,7 +179,6 @@ public class JMeterContext {
>   
>       /**
>        * Internally called by JMeter, never call it directly
> -     * @param engine {@link StandardJMeterEngine}
>        */
>       public void setEngine(StandardJMeterEngine engine) {
>           this.engine = engine;
> @@ -206,7 +190,6 @@ public class JMeterContext {
>   
>       /**
>        * Internally called by JMeter, never call it directly
> -     * @param b boolean
>        */
>       public void setSamplingStarted(boolean b) {
>           samplingStarted = b;
> @@ -214,9 +197,6 @@ public class JMeterContext {
>   
>       /**
>        * if set to <code>true</code> a restart of the loop will occur
> -     *
> -     * @param restartNextLoop
> -     *            flag whether restart will occur
>        */
>       public void setStartNextThreadLoop(boolean restartNextLoop) {
>           this.restartNextLoop = restartNextLoop;
> @@ -225,8 +205,6 @@ public class JMeterContext {
>       /**
>        * if set to <code>true</code> current loop iteration will be interrupted
and
>        * JMeter will go to next iteration
> -     *
> -     * @return boolean restartNextLoop
>        */
>       public boolean isStartNextThreadLoop() {
>           return restartNextLoop;
> @@ -236,8 +214,6 @@ public class JMeterContext {
>        * if set to <code>true</code> current loop iteration will be interrupted
and
>        * JMeter will go to next iteration
>        *
> -     * @param restartNextLoop
> -     *            flag whether restart will occur
>        * @deprecated use {@link JMeterContext#setStartNextThreadLoop(boolean)}
>        */
>       @Deprecated
> @@ -246,9 +222,7 @@ public class JMeterContext {
>       }
>   
>       /**
> -     * a restart of the loop was required ?
> -     * @return the restartNextLoop
> -     * @deprecated use {@link JMeterContext#isRestartNextLoop()}
> +     * @deprecated use {@link JMeterContext#isStartNextThreadLoop()}
>        */
>       @Deprecated
>       public boolean isRestartNextLoop() {
> @@ -260,7 +234,7 @@ public class JMeterContext {
>        * Internally called by JMeter, never call it directly
>        */
>       public void cleanAfterSample() {
> -        if(previousResult != null) {
> +        if (previousResult != null) {
>               previousResult.cleanAfterSample();
>           }
>           samplerContext.clear();
> @@ -276,15 +250,11 @@ public class JMeterContext {
>   
>       /**
>        * Internally called by JMeter, never call it directly
> -     * @param recording true if we are recording
>        */
>       public void setRecording(boolean recording) {
>           this.recording = recording;
>       }
>   
> -    /**
> -     * @return the recording
> -     */
>       public boolean isRecording() {
>           return recording;
>       }
>
>


Mime
View raw message