jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject svn commit: r1721392 - in /jmeter/trunk/src/core/org/apache/jmeter/report/processor: ListResultData.java MapResultData.java ResultData.java ValueResultData.java
Date Tue, 22 Dec 2015 13:27:08 GMT
Author: fschumacher
Date: Tue Dec 22 13:27:07 2015
New Revision: 1721392

URL: http://svn.apache.org/viewvc?rev=1721392&view=rev
Log:
Use interface for variable declaration.
Remove null check and document need for non null parameter.

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/ListResultData.java
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/MapResultData.java
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/ResultData.java
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/ValueResultData.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/ListResultData.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/ListResultData.java?rev=1721392&r1=1721391&r2=1721392&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/ListResultData.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/ListResultData.java Tue Dec 22
13:27:07 2015
@@ -19,8 +19,7 @@ package org.apache.jmeter.report.process
 
 import java.util.ArrayList;
 import java.util.Iterator;
-
-import org.apache.jmeter.report.core.ArgumentNullException;
+import java.util.List;
 
 /**
  * The class ListResultData provides a list of results from sample processing.
@@ -30,7 +29,7 @@ import org.apache.jmeter.report.core.Arg
 public class ListResultData implements ResultData, Iterable<ResultData> {
 
     /** The items. */
-    private ArrayList<ResultData> items = new ArrayList<>();
+    private List<ResultData> items = new ArrayList<>();
 
     /*
      * (non-Javadoc)
@@ -41,9 +40,6 @@ public class ListResultData implements R
      */
     @Override
     public <TVisit> TVisit accept(ResultDataVisitor<TVisit> visitor) {
-        if (visitor == null) {
-            throw new ArgumentNullException("visitor");
-        }
         return visitor.visitListResult(this);
     }
 

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/MapResultData.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/MapResultData.java?rev=1721392&r1=1721391&r2=1721392&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/MapResultData.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/MapResultData.java Tue Dec 22
13:27:07 2015
@@ -18,11 +18,10 @@
 package org.apache.jmeter.report.processor;
 
 import java.util.HashMap;
+import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
 
-import org.apache.jmeter.report.core.ArgumentNullException;
-
 /**
  * The class MapResultData provides a hash map of results from samples
  * processing.
@@ -31,7 +30,7 @@ import org.apache.jmeter.report.core.Arg
  */
 public class MapResultData implements ResultData {
 
-    private HashMap<String, ResultData> map = new HashMap<>();
+    private Map<String, ResultData> map = new HashMap<>();
 
     /*
      * (non-Javadoc)
@@ -42,9 +41,6 @@ public class MapResultData implements Re
      */
     @Override
     public <TVisit> TVisit accept(ResultDataVisitor<TVisit> visitor) {
-        if (visitor == null) {
-            throw new ArgumentNullException("visitor");
-        }
         return visitor.visitMapResult(this);
     }
 

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/ResultData.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/ResultData.java?rev=1721392&r1=1721391&r2=1721392&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/ResultData.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/ResultData.java Tue Dec 22 13:27:07
2015
@@ -28,7 +28,7 @@ public interface ResultData {
      * Accepts the specified visitor.
      *
      * @param visitor
-     *            the visitor
+     *            the visitor (must not be {@code null})
      */
     <TVisit> TVisit accept(ResultDataVisitor<TVisit> visitor);
 }

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/ValueResultData.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/ValueResultData.java?rev=1721392&r1=1721391&r2=1721392&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/ValueResultData.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/ValueResultData.java Tue Dec
22 13:27:07 2015
@@ -17,8 +17,6 @@
  */
 package org.apache.jmeter.report.processor;
 
-import org.apache.jmeter.report.core.ArgumentNullException;
-
 /**
  * The class ValueResultData provides a value result from samples processing.
  * 
@@ -72,9 +70,6 @@ public class ValueResultData implements
      */
     @Override
     public <TVisit> TVisit accept(ResultDataVisitor<TVisit> visitor) {
-        if (visitor == null) {
-            throw new ArgumentNullException("visitor");
-        }
         return visitor.visitValueResult(this);
     }
 



Mime
View raw message