jmeter-commits mailing list archives

Author: fschumacher
Date: Tue Dec 22 12:24:03 2015
New Revision: 1721383

URL: http://svn.apache.org/viewvc?rev=1721383&view=rev
Log:
Change ArgumentNullException to NPE and document the need for non null parameter

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleMetadata.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleMetadata.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleMetadata.java?rev=1721383&r1=1721382&r2=1721383&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleMetadata.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleMetadata.java Tue Dec 22 12:24:03
2015
@@ -23,6 +23,7 @@ import java.util.List;
 import java.util.TreeMap;
 
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Validate;
 import org.apache.jmeter.samplers.SampleSaveConfiguration;
 import org.apache.jmeter.save.CSVSaveService;
 
@@ -52,12 +53,10 @@ public class SampleMetadata {
      * @param separator
      *            The character used for column separation
      * @param columns
-     *            The list of columns names
+     *            The list of columns names (must not be {@code null})
      */
     public SampleMetadata(char separator, String... columns) {
-        if (columns == null) {
-            throw new ArgumentNullException("columns");
-        }
+        Validate.notNull(columns, "columns must not be null");
         initialize(separator, Arrays.asList(columns));
     }