jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject svn commit: r1721359 - in /jmeter/trunk/src/core/org/apache/jmeter/report/core: ControllerSamplePredicate.java SamplePredicate.java
Date Tue, 22 Dec 2015 11:27:22 GMT
Author: fschumacher
Date: Tue Dec 22 11:27:21 2015
New Revision: 1721359

URL: http://svn.apache.org/viewvc?rev=1721359&view=rev
Log:
Remove null check and document the need for non null parameter in javadoc.

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/core/ControllerSamplePredicate.java
    jmeter/trunk/src/core/org/apache/jmeter/report/core/SamplePredicate.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/ControllerSamplePredicate.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/ControllerSamplePredicate.java?rev=1721359&r1=1721358&r2=1721359&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/ControllerSamplePredicate.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/ControllerSamplePredicate.java Tue
Dec 22 11:27:21 2015
@@ -33,10 +33,6 @@ public class ControllerSamplePredicate i
      */
     @Override
     public boolean matches(Sample sample) {
-        if (sample == null) {
-            throw new ArgumentNullException("sample");
-        }
-
         return sample.isController();
     }
 

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/SamplePredicate.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/SamplePredicate.java?rev=1721359&r1=1721358&r2=1721359&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/SamplePredicate.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/SamplePredicate.java Tue Dec 22 11:27:21
2015
@@ -29,8 +29,8 @@ public interface SamplePredicate {
      * Defines if the specified sample matches the current predicate.
      *
      * @param sample
-     *            the sample to test
-     * @return true, if successful; otherwise false
+     *            the sample to test (must not be {@code null})
+     * @return {@code true}, if successful; otherwise {@code false}
      */
     boolean matches(Sample sample);
 }



Mime
View raw message