jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject svn commit: r1721353 - /jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
Date Tue, 22 Dec 2015 11:17:39 GMT
Author: fschumacher
Date: Tue Dec 22 11:17:39 2015
New Revision: 1721353

URL: http://svn.apache.org/viewvc?rev=1721353&view=rev
Log:
Remove null check for inputFile and document the need for non null arguments in the javadoc.

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java?rev=1721353&r1=1721352&r2=1721353&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java Tue Dec 22 11:17:39
2015
@@ -68,7 +68,7 @@ public class CsvSampleReader implements
      * Instantiates a new csv sample reader.
      *
      * @param inputFile
-     *            the input file
+     *            the input file (must not be {@code null})
      * @param separator
      *            the separator
      * @param useSaveSampleCfg
@@ -83,7 +83,7 @@ public class CsvSampleReader implements
      * Instantiates a new csv sample reader.
      *
      * @param inputFile
-     *            the input file
+     *            the input file (must not be {@code null})
      * @param metadata
      *            the metadata
      */
@@ -93,10 +93,6 @@ public class CsvSampleReader implements
 
     private CsvSampleReader(File inputFile, SampleMetadata metadata,
             char separator, boolean useSaveSampleCfg) {
-        if (inputFile == null) {
-            throw new ArgumentNullException("inputFile");
-        }
-
         if (!(inputFile.isFile() && inputFile.canRead())) {
             throw new IllegalArgumentException(inputFile.getAbsolutePath()
                     + "does not exist or is not readable");



Mime
View raw message