jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject svn commit: r1656178 - in /jmeter/trunk: src/components/org/apache/jmeter/visualizers/PropertyControlGui.java test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java
Date Sat, 31 Jan 2015 11:02:21 GMT
Author: fschumacher
Date: Sat Jan 31 11:02:21 2015
New Revision: 1656178

URL: http://svn.apache.org/r1656178
Log:
Bug: 57110
Assign variable only once.
Bugzilla Id: 57110

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
    jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java?rev=1656178&r1=1656177&r2=1656178&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java Sat
Jan 31 11:02:21 2015
@@ -227,20 +227,16 @@ public class PropertyControlGui extends
      * Initialize the components and layout of this component.
      */
     private void init() {
-        JPanel p = this;
-
         setLayout(new BorderLayout(0, 5));
         setBorder(makeBorder());
         add(makeTitlePanel(), BorderLayout.NORTH);
-        p = new JPanel();
 
+        JPanel p = new JPanel();
         p.setLayout(new BorderLayout());
-
         p.add(makeLabelPanel(), BorderLayout.NORTH);
         p.add(makeMainPanel(), BorderLayout.CENTER);
         // Force a minimum table height of 70 pixels
         p.add(Box.createVerticalStrut(70), BorderLayout.WEST);
-        //p.add(makeButtonPanel(), BorderLayout.SOUTH);
 
         add(p, BorderLayout.CENTER);
         table.revalidate();

Modified: jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java?rev=1656178&r1=1656177&r2=1656178&view=diff
==============================================================================
--- jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java (original)
+++ jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java Sat Jan 31 11:02:21
2015
@@ -160,21 +160,15 @@ public class GenerateTreeGui extends Abs
      * Initialize the components and layout of this component.
      */
     private void init() {
-        JPanel p = this;
-
         setLayout(new BorderLayout(0, 5));
         setBorder(makeBorder());
         add(makeTitlePanel(), BorderLayout.NORTH);
-        p = new JPanel();
 
+        JPanel p = new JPanel();
         p.setLayout(new BorderLayout());
-
         p.add(makeLabelPanel(), BorderLayout.NORTH);
-//        p.add(makeMainPanel(), BorderLayout.CENTER);
         // Force a minimum table height of 70 pixels
         p.add(Box.createVerticalStrut(70), BorderLayout.WEST);
-        //p.add(makeButtonPanel(), BorderLayout.SOUTH);
-
         add(p, BorderLayout.CENTER);
     }
     /**



Mime
View raw message