jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1652459 - in /jmeter/trunk: src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java xdocs/changes.xml
Date Fri, 16 Jan 2015 17:01:08 GMT
Author: pmouawad
Date: Fri Jan 16 17:01:08 2015
New Revision: 1652459

URL: http://svn.apache.org/r1652459
Log:
Bug 57449 - Distributed Testing: Stripped modes do not strip responses from SubResults (affects
load tests that use Download of embedded resources)
Bugzilla Id: 57449

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java?rev=1652459&r1=1652458&r2=1652459&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java Fri Jan
16 17:01:08 2015
@@ -76,8 +76,11 @@ public class DataStrippingSampleSender e
         SampleResult result = event.getResult();
         if(result.isSuccessful()) {
             // Compute bytes before stripping
-            result.setBytes(result.getBytes());
-            result.setResponseData(new byte[0]);
+            stipResponse(result);
+            // see Bug 57449
+            for (SampleResult subResult : result.getSubResults()) {
+                stipResponse(subResult);                
+            }
         }
         if(decoratedSender == null)
         {
@@ -94,6 +97,15 @@ public class DataStrippingSampleSender e
     }
 
     /**
+     * Strip response but fill in bytes field.
+     * @param result {@link SampleResult}
+     */
+    private final void stipResponse(SampleResult result) {
+        result.setBytes(result.getBytes());
+        result.setResponseData(SampleResult.EMPTY_BA);
+    }
+
+    /**
      * Processed by the RMI server code; acts as testStarted().
      *
      * @return this

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1652459&r1=1652458&r2=1652459&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Fri Jan 16 17:01:08 2015
@@ -156,6 +156,7 @@ See  <bugzilla>56357</bugzilla> for deta
 <ul>
 <li><bug>57262</bug>Aggregate Report, Aggregate Graph and Summary Report
export : headers use keys instead of labels</li>
 <li><bug>57346</bug>Summariser : The + (difference) reports show wrong
elapsed time and throughput</li>
+<li><bug>57449</bug>Distributed Testing: Stripped modes do not strip responses
from SubResults (affects load tests that use Download of embedded resources). Contributed
by Ubik Load Pack (support at ubikloadpack.com)</li>
 </ul>
 
 <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>



Mime
View raw message