Author: pmouawad
Date: Mon Sep 29 18:47:05 2014
New Revision: 1628255

URL: http://svn.apache.org/r1628255
Log:
Bug 57025 - SaveService : Better defaults, save thread counts by default
Bugzilla Id: 57025

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/bin/testfiles/jmeter-batch.properties
    jmeter/trunk/bin/testfiles/jmetertest.properties
    jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/listeners.xml

Modified: jmeter/trunk/bin/jmeter.properties
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1628255&r1=1628254&r2=1628255&view=diff
==============================================================================
--- jmeter/trunk/bin/jmeter.properties (original)
+++ jmeter/trunk/bin/jmeter.properties Mon Sep 29 18:47:05 2014
@@ -473,7 +473,7 @@ log_level.jorphan=INFO
 #jmeter.save.saveservice.url=false
 #jmeter.save.saveservice.filename=false
 #jmeter.save.saveservice.hostname=false
-#jmeter.save.saveservice.thread_counts=false
+#jmeter.save.saveservice.thread_counts=true
 #jmeter.save.saveservice.sample_count=false
 #jmeter.save.saveservice.idle_time=false
 

Modified: jmeter/trunk/bin/testfiles/jmeter-batch.properties
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/jmeter-batch.properties?rev=1628255&r1=1628254&r2=1628255&view=diff
==============================================================================
--- jmeter/trunk/bin/testfiles/jmeter-batch.properties (original)
+++ jmeter/trunk/bin/testfiles/jmeter-batch.properties Mon Sep 29 18:47:05 2014
@@ -21,3 +21,6 @@
 log_level.jmeter=WARN
 # Revert to original default mode
 mode=Standard
+
+# Since JMeter 2.12, defaults for this property is true
+jmeter.save.saveservice.thread_counts=false
\ No newline at end of file

Modified: jmeter/trunk/bin/testfiles/jmetertest.properties
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/jmetertest.properties?rev=1628255&r1=1628254&r2=1628255&view=diff
==============================================================================
--- jmeter/trunk/bin/testfiles/jmetertest.properties (original)
+++ jmeter/trunk/bin/testfiles/jmetertest.properties Mon Sep 29 18:47:05 2014
@@ -156,6 +156,8 @@ jmeter.save.saveservice.output_format=cs
 #jmeter.save.saveservice.successful=true
 #jmeter.save.saveservice.thread_name=true
 jmeter.save.saveservice.time=false
+# Since JMeter 2.12, defaults for this property is true
+jmeter.save.saveservice.thread_counts=false
 
 # legitimate values: none, ms, or a format suitable for SimpleDateFormat
 #jmeter.save.saveservice.timestamp_format=none

Modified: jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java?rev=1628255&r1=1628254&r2=1628255&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java Mon Sep 29 18:47:05 2014
@@ -393,7 +393,7 @@ public class SampleSaveConfiguration imp
             _xml = false;
         }
 
-        _threadCounts=TRUE.equalsIgnoreCase(props.getProperty(SAVE_THREAD_COUNTS, FALSE));
+        _threadCounts=TRUE.equalsIgnoreCase(props.getProperty(SAVE_THREAD_COUNTS, TRUE));
 
         _sampleCount=TRUE.equalsIgnoreCase(props.getProperty(SAVE_SAMPLE_COUNT, FALSE));
 

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1628255&r1=1628254&r2=1628255&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Mon Sep 29 18:47:05 2014
@@ -267,6 +267,7 @@ for details on configuring this componen
 <li><bugzilla>56119</bugzilla> - File uploads fail every other attempt using timers. Enable idle timeouts for servers that don't send Keep-Alive headers.</li>
 <li><bugzilla>56272</bugzilla> - MirrorServer should support query parameters for status and redirects</li>
 <li><bugzilla>56772</bugzilla> - Handle IE Conditional comments when parsing embedded resources</li>
+<li><bugzilla>57026</bugzilla> - HTTP(S) Test Script Recorder : Better default settings. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
 </ul>
 
 <h3>Other samplers</h3>
@@ -287,6 +288,7 @@ for details on configuring this componen
 <li><bugzilla>56228</bugzilla> - View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering</li>
 <li><bugzilla>56349</bugzilla> - "summary" is a bad name for a Generate Summary Results component, documentation clarified</li>
 <li><bugzilla>56769</bugzilla> - Adds the ability for the Response Time Graph listener to save/restore format settings in/from the jmx file</li>
+<li><bugzilla>57025</bugzilla> - SaveService : Better defaults, save thread counts by default</li>
 </ul>
 
 <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>

Modified: jmeter/trunk/xdocs/usermanual/listeners.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/listeners.xml?rev=1628255&r1=1628254&r2=1628255&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/listeners.xml (original)
+++ jmeter/trunk/xdocs/usermanual/listeners.xml Mon Sep 29 18:47:05 2014
@@ -145,7 +145,7 @@ The full set of properties that affect r
 #jmeter.save.saveservice.url=false
 #jmeter.save.saveservice.filename=false
 #jmeter.save.saveservice.hostname=false
-#jmeter.save.saveservice.thread_counts=false
+#jmeter.save.saveservice.thread_counts=true
 #jmeter.save.saveservice.sample_count=false
 #jmeter.save.saveservice.idle_time=false