From commits-return-3290-apmail-jmeter-commits-archive=jmeter.apache.org@jmeter.apache.org Sat Sep 13 12:54:00 2014 Return-Path: X-Original-To: apmail-jmeter-commits-archive@minotaur.apache.org Delivered-To: apmail-jmeter-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 688A111ADB for ; Sat, 13 Sep 2014 12:54:00 +0000 (UTC) Received: (qmail 61709 invoked by uid 500); 13 Sep 2014 12:53:59 -0000 Delivered-To: apmail-jmeter-commits-archive@jmeter.apache.org Received: (qmail 61678 invoked by uid 500); 13 Sep 2014 12:53:59 -0000 Mailing-List: contact commits-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list commits@jmeter.apache.org Received: (qmail 61669 invoked by uid 99); 13 Sep 2014 12:53:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Sep 2014 12:53:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Sep 2014 12:53:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 7D05823889E0; Sat, 13 Sep 2014 12:53:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1624732 - /jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java Date: Sat, 13 Sep 2014 12:53:38 -0000 To: commits@jmeter.apache.org From: pmouawad@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140913125338.7D05823889E0@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: pmouawad Date: Sat Sep 13 12:53:38 2014 New Revision: 1624732 URL: http://svn.apache.org/r1624732 Log: Clarify why volatile is not needed and removed wrong doc Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java?rev=1624732&r1=1624731&r2=1624732&view=diff ============================================================================== --- jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java (original) +++ jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java Sat Sep 13 12:53:38 2014 @@ -62,6 +62,9 @@ public class ReceiveSubscriber implement */ private final LinkedBlockingQueue queue; + /** + * No need for sync as this variable is only accessed by JMeterThread thread + */ private boolean connectionStarted; /** @@ -272,7 +275,7 @@ public class ReceiveSubscriber implement * Then it closes the subscriber, session and connection. */ @Override - public void close() { // called from threadFinished() thread + public void close() { log.debug("close()"); try { if(connection != null && connectionStarted) {