jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1624733 - in /jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms: client/ReceiveSubscriber.java sampler/SubscriberSampler.java
Date Sat, 13 Sep 2014 12:59:45 GMT
Author: sebb
Date: Sat Sep 13 12:59:44 2014
New Revision: 1624733

URL: http://svn.apache.org/r1624733
Log:
Clarify docs

Modified:
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java

Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java?rev=1624733&r1=1624732&r2=1624733&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
(original)
+++ jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
Sat Sep 13 12:59:44 2014
@@ -63,7 +63,7 @@ public class ReceiveSubscriber implement
     private final LinkedBlockingQueue<Message> queue;
 
     /**
-     * No need for sync as this variable is only accessed by JMeterThread thread
+     * No need for volatile as this variable is only accessed by a single thread
      */
     private boolean connectionStarted;
 
@@ -275,7 +275,7 @@ public class ReceiveSubscriber implement
      * Then it closes the subscriber, session and connection.
      */
     @Override
-    public void close() { 
+    public void close() { // called by SubscriberSampler#threadFinished()
         log.debug("close()");
         try {
             if(connection != null && connectionStarted) {

Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java?rev=1624733&r1=1624732&r2=1624733&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java
(original)
+++ jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java
Sat Sep 13 12:59:44 2014
@@ -63,7 +63,8 @@ public class SubscriberSampler extends B
     // This is the maximum time the sampler can be blocked.
     private static final long DEFAULT_WAIT = 500L;
 
-    // No need to synch/ - only used by sampler and ClientPool (which does its own synch)
+    // No need to synch/ - only used by sampler
+    // Note: not currently added to the ClientPool
     private transient ReceiveSubscriber SUBSCRIBER = null;
 
     private transient volatile boolean interrupted = false;



Mime
View raw message