jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1624732 - /jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
Date Sat, 13 Sep 2014 12:53:38 GMT
Author: pmouawad
Date: Sat Sep 13 12:53:38 2014
New Revision: 1624732

URL: http://svn.apache.org/r1624732
Log:
Clarify why volatile is not needed and removed wrong doc

Modified:
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java

Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java?rev=1624732&r1=1624731&r2=1624732&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
(original)
+++ jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
Sat Sep 13 12:53:38 2014
@@ -62,6 +62,9 @@ public class ReceiveSubscriber implement
      */
     private final LinkedBlockingQueue<Message> queue;
 
+    /**
+     * No need for sync as this variable is only accessed by JMeterThread thread
+     */
     private boolean connectionStarted;
 
     /**
@@ -272,7 +275,7 @@ public class ReceiveSubscriber implement
      * Then it closes the subscriber, session and connection.
      */
     @Override
-    public void close() { // called from threadFinished() thread
+    public void close() { 
         log.debug("close()");
         try {
             if(connection != null && connectionStarted) {



Mime
View raw message