From commits-return-1405-apmail-jmeter-commits-archive=jmeter.apache.org@jmeter.apache.org Mon Sep 3 20:14:28 2012 Return-Path: X-Original-To: apmail-jmeter-commits-archive@minotaur.apache.org Delivered-To: apmail-jmeter-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 550C6DD71 for ; Mon, 3 Sep 2012 20:14:28 +0000 (UTC) Received: (qmail 48391 invoked by uid 500); 3 Sep 2012 20:14:28 -0000 Delivered-To: apmail-jmeter-commits-archive@jmeter.apache.org Received: (qmail 48366 invoked by uid 500); 3 Sep 2012 20:14:28 -0000 Mailing-List: contact commits-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list commits@jmeter.apache.org Received: (qmail 48359 invoked by uid 99); 3 Sep 2012 20:14:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 20:14:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 20:14:26 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id B03A9238890D for ; Mon, 3 Sep 2012 20:13:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1380341 - in /jmeter/trunk/test/src/org/apache/jmeter/assertions: ResponseAssertionTest.java SizeAssertionTest.java Date: Mon, 03 Sep 2012 20:13:43 -0000 To: commits@jmeter.apache.org From: pmouawad@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120903201343.B03A9238890D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: pmouawad Date: Mon Sep 3 20:13:43 2012 New Revision: 1380341 URL: http://svn.apache.org/viewvc?rev=1380341&view=rev Log: Make field final Make field local Modified: jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java Modified: jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java?rev=1380341&r1=1380340&r2=1380341&view=diff ============================================================================== --- jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java (original) +++ jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java Mon Sep 3 20:13:43 2012 @@ -33,19 +33,17 @@ public class ResponseAssertionTest exte public ResponseAssertionTest() { } - private JMeterContext jmctx; private ResponseAssertion assertion; private SampleResult sample; - private JMeterVariables vars; private AssertionResult result; @Override public void setUp() throws MalformedURLException { - jmctx = JMeterContextService.getContext(); + JMeterContext jmctx = JMeterContextService.getContext(); assertion = new ResponseAssertion(); assertion.setThreadContext(jmctx); sample = new SampleResult(); - vars = new JMeterVariables(); + JMeterVariables vars = new JMeterVariables(); jmctx.setVariables(vars); jmctx.setPreviousResult(sample); sample.setResponseData("response Data\nline 2\n\nEOF", null); Modified: jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java?rev=1380341&r1=1380340&r2=1380341&view=diff ============================================================================== --- jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java (original) +++ jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java Mon Sep 3 20:13:43 2012 @@ -26,21 +26,19 @@ import org.apache.jmeter.threads.JMeterV public class SizeAssertionTest extends JMeterTestCase{ - private JMeterContext jmctx; private SizeAssertion assertion; private SampleResult sample1,sample0; - private JMeterVariables vars; private AssertionResult result; - private String data1 = "response Data\n" + "line 2\n\nEOF"; - private int data1Len=data1.length(); + private final String data1 = "response Data\n" + "line 2\n\nEOF"; + private final int data1Len=data1.length(); @Override public void setUp() { - jmctx = JMeterContextService.getContext(); + JMeterContext jmctx = JMeterContextService.getContext(); assertion = new SizeAssertion(); assertion.setThreadContext(jmctx); assertion.setTestFieldResponseBody(); - vars = new JMeterVariables(); + JMeterVariables vars = new JMeterVariables(); jmctx.setVariables(vars); sample0 = new SampleResult(); sample1 = new SampleResult(); @@ -151,9 +149,9 @@ public class SizeAssertionTest extends J // TODO - need a lot more tests private void assertPassed() throws Exception{ - if (null != result.getFailureMessage()){ + // if (null != result.getFailureMessage()){ //System.out.println(result.getFailureMessage());// debug - } + //} assertNull("Failure message should be null",result.getFailureMessage()); assertFalse(result.isError()); assertFalse(result.isFailure());