From commits-return-1401-apmail-jmeter-commits-archive=jmeter.apache.org@jmeter.apache.org Mon Sep 3 20:09:56 2012 Return-Path: X-Original-To: apmail-jmeter-commits-archive@minotaur.apache.org Delivered-To: apmail-jmeter-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 51502DD57 for ; Mon, 3 Sep 2012 20:09:56 +0000 (UTC) Received: (qmail 38982 invoked by uid 500); 3 Sep 2012 20:09:56 -0000 Delivered-To: apmail-jmeter-commits-archive@jmeter.apache.org Received: (qmail 38961 invoked by uid 500); 3 Sep 2012 20:09:56 -0000 Mailing-List: contact commits-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list commits@jmeter.apache.org Received: (qmail 38952 invoked by uid 99); 3 Sep 2012 20:09:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 20:09:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 20:09:54 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 86BC32388962 for ; Mon, 3 Sep 2012 20:09:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1380337 - /jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLSchemaAssertion.java Date: Mon, 03 Sep 2012 20:09:10 -0000 To: commits@jmeter.apache.org From: pmouawad@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120903200910.86BC32388962@eris.apache.org> Author: pmouawad Date: Mon Sep 3 20:09:10 2012 New Revision: 1380337 URL: http://svn.apache.org/viewvc?rev=1380337&view=rev Log: Add final to field Add logger.isDebugEnabled Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLSchemaAssertion.java Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLSchemaAssertion.java URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLSchemaAssertion.java?rev=1380337&r1=1380336&r2=1380337&view=diff ============================================================================== --- jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLSchemaAssertion.java (original) +++ jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLSchemaAssertion.java Mon Sep 3 20:09:10 2012 @@ -163,7 +163,7 @@ public class XMLSchemaAssertion extends * SAXErrorHandler class */ private static class SAXErrorHandler implements ErrorHandler { - private AssertionResult result; + private final AssertionResult result; public SAXErrorHandler(AssertionResult result) { this.result = result; @@ -175,7 +175,9 @@ public class XMLSchemaAssertion extends public void error(SAXParseException exception) throws SAXParseException { String msg = "error: " + errorDetails(exception); - log.debug(msg); + if(log.isDebugEnabled()) { + log.debug(msg); + } result.setFailureMessage(msg); result.setError(true); throw exception; @@ -188,7 +190,9 @@ public class XMLSchemaAssertion extends public void fatalError(SAXParseException exception) throws SAXParseException { String msg = "fatal: " + errorDetails(exception); - log.debug(msg); + if(log.isDebugEnabled()) { + log.debug(msg); + } result.setFailureMessage(msg); result.setError(true); throw exception; @@ -200,7 +204,9 @@ public class XMLSchemaAssertion extends public void warning(SAXParseException exception) throws SAXParseException { String msg = "warning: " + errorDetails(exception); - log.debug(msg); + if(log.isDebugEnabled()) { + log.debug(msg); + } result.setFailureMessage(msg); // result.setError(true); // TODO is this the correct strategy? // throw exception; // allow assertion to pass