From commits-return-1394-apmail-jmeter-commits-archive=jmeter.apache.org@jmeter.apache.org Mon Sep 3 19:40:28 2012 Return-Path: X-Original-To: apmail-jmeter-commits-archive@minotaur.apache.org Delivered-To: apmail-jmeter-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53A13DBAB for ; Mon, 3 Sep 2012 19:40:28 +0000 (UTC) Received: (qmail 55852 invoked by uid 500); 3 Sep 2012 19:40:28 -0000 Delivered-To: apmail-jmeter-commits-archive@jmeter.apache.org Received: (qmail 55835 invoked by uid 500); 3 Sep 2012 19:40:28 -0000 Mailing-List: contact commits-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list commits@jmeter.apache.org Received: (qmail 55826 invoked by uid 99); 3 Sep 2012 19:40:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 19:40:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 19:40:26 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 6A223238897F for ; Mon, 3 Sep 2012 19:39:42 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1380318 - /jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java Date: Mon, 03 Sep 2012 19:39:42 -0000 To: commits@jmeter.apache.org From: pmouawad@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120903193942.6A223238897F@eris.apache.org> Author: pmouawad Date: Mon Sep 3 19:39:41 2012 New Revision: 1380318 URL: http://svn.apache.org/viewvc?rev=1380318&view=rev Log: Avoid StringBuilder creation in loops Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java?rev=1380318&r1=1380317&r2=1380318&view=diff ============================================================================== --- jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java (original) +++ jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java Mon Sep 3 19:39:41 2012 @@ -68,6 +68,7 @@ public class CompareAssertion extends Ab long prevTime = -1; SampleResult prevResult = null; boolean success = true; + StringBuilder buf = new StringBuilder(); for(SampleResult sResult : responses) { long currentTime = sResult.getTime(); if (prevTime != -1) { @@ -76,11 +77,11 @@ public class CompareAssertion extends Ab } if (!success) { result.setFailure(true); - StringBuilder buf = new StringBuilder(); + buf.setLength(0); appendResultDetails(buf, prevResult); buf.append(JMeterUtils.getResString("comparison_response_time")).append(prevTime); result.addToBaseResult(buf.toString()); - buf = new StringBuilder(); + buf.setLength(0); appendResultDetails(buf, sResult); buf.append(JMeterUtils.getResString("comparison_response_time")).append(currentTime); result.addToSecondaryResult(buf.toString()); @@ -101,6 +102,7 @@ public class CompareAssertion extends Ab String prevContent = null; SampleResult prevResult = null; boolean success = true; + StringBuilder buf = new StringBuilder(); for (SampleResult sResult : responses) { String currentContent = sResult.getResponseDataAsString(); currentContent = filterString(currentContent); @@ -109,11 +111,11 @@ public class CompareAssertion extends Ab } if (!success) { result.setFailure(true); - StringBuilder buf = new StringBuilder(); + buf.setLength(0); appendResultDetails(buf, prevResult); buf.append(prevContent); result.addToBaseResult(buf.toString()); - buf = new StringBuilder(); + buf.setLength(0); appendResultDetails(buf, sResult); buf.append(currentContent); result.addToSecondaryResult(buf.toString());