jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1381375 - in /jmeter/trunk/src/components/org/apache/jmeter/visualizers: GraphVisualizer.java PropertyControlGui.java RequestPanel.java RespTimeGraphVisualizer.java
Date Wed, 05 Sep 2012 21:16:30 GMT
Author: pmouawad
Date: Wed Sep  5 21:16:29 2012
New Revision: 1381375

URL: http://svn.apache.org/viewvc?rev=1381375&view=rev
Log:
Make fields final
Make field local

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/GraphVisualizer.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestPanel.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/GraphVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/GraphVisualizer.java?rev=1381375&r1=1381374&r2=1381375&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/GraphVisualizer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/GraphVisualizer.java Wed Sep
 5 21:16:29 2012
@@ -60,9 +60,9 @@ public class GraphVisualizer extends Abs
 
     private static final String ZERO = "0";  //$NON-NLS-1$
 
-    private NumberFormat nf = NumberFormat.getInstance(); // OK, because used in synchronised
method
+    private final NumberFormat nf = NumberFormat.getInstance(); // OK, because used in synchronised
method
 
-    private CachingStatCalculator model;
+    private final CachingStatCalculator model;
 
     private JTextField maxYField = null;
 
@@ -70,9 +70,9 @@ public class GraphVisualizer extends Abs
 
     private JTextField noSamplesField = null;
 
-    private String minute = JMeterUtils.getResString("minute"); // $NON-NLS-1$
+    private final String minute = JMeterUtils.getResString("minute"); // $NON-NLS-1$
 
-    private Graph graph;
+    private final Graph graph;
 
     private JCheckBox data;
 

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java?rev=1381375&r1=1381374&r2=1381375&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java Wed
Sep  5 21:16:29 2012
@@ -71,10 +71,11 @@ public class PropertyControlGui extends 
 
     private static final String JMETER = "jmeter"; // $NON-NLS-1$
 
-    private JCheckBox systemButton = new JCheckBox("System");
-    private JCheckBox jmeterButton = new JCheckBox("JMeter");
+    private final JCheckBox systemButton = new JCheckBox("System");
+    
+    private final JCheckBox jmeterButton = new JCheckBox("JMeter");
 
-    private JLabel tableLabel = new JLabel("Properties");
+    private final JLabel tableLabel = new JLabel("Properties");
 
     /** The table containing the list of arguments. */
     private transient JTable table;

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestPanel.java?rev=1381375&r1=1381374&r2=1381375&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestPanel.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestPanel.java Wed Sep  5
21:16:29 2012
@@ -42,11 +42,9 @@ public class RequestPanel {
 
     private static final Logger log = LoggingManager.getLoggerForClass();
 
-    private LinkedList<RequestView> listRequestView;
+    private final LinkedList<RequestView> listRequestView;
 
-    private JTabbedPane tabbedRequest;
-
-    private JPanel panel;
+    private final JPanel panel;
 
     /**
      * Find and instanciate all class that extend RequestView
@@ -81,7 +79,7 @@ public class RequestPanel {
         }
         
         // Prepare the Request tabbed pane
-        tabbedRequest = new JTabbedPane(SwingConstants.BOTTOM);
+        JTabbedPane tabbedRequest = new JTabbedPane(SwingConstants.BOTTOM);
         for (RequestView requestView : listRequestView) {
             requestView.init();
             tabbedRequest.addTab(requestView.getLabel(), requestView.getPanel());

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java?rev=1381375&r1=1381374&r2=1381375&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
(original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
Wed Sep  5 21:16:29 2012
@@ -96,8 +96,6 @@ public class RespTimeGraphVisualizer ext
 
     private RespTimeGraphChart graphPanel = null;
 
-    private JPanel settingsPane = null;
-
     private final JTabbedPane tabbedGraph = new JTabbedPane(SwingConstants.TOP);
     
     private boolean saveGraphToFile = false;
@@ -118,7 +116,7 @@ public class RespTimeGraphVisualizer ext
     private final JButton displayButton =
             new JButton(JMeterUtils.getResString("aggregate_graph_display")); //$NON-NLS-1$
     
-    private JButton saveGraph =
+    private final JButton saveGraph =
             new JButton(JMeterUtils.getResString("aggregate_graph_save")); //$NON-NLS-1$
 
     private final JCheckBox samplerSelection = new JCheckBox(JMeterUtils.getResString("graph_resp_time_series_selection"),
false); //$NON-NLS-1$
@@ -195,7 +193,7 @@ public class RespTimeGraphVisualizer ext
     private final List<Color> listColors = Colors.getColors();
 
     // Use implementation instead of Interface as we need it to be cloneable
-    private HashMap<Long, Long> internalMap = new HashMap<Long, Long>(); // internal
list of all results
+    private final HashMap<Long, Long> internalMap = new HashMap<Long, Long>();
// internal list of all results
 
     public RespTimeGraphVisualizer() {
         init();
@@ -379,7 +377,7 @@ public class RespTimeGraphVisualizer ext
         mainPanel.setLayout(new BoxLayout(mainPanel, BoxLayout.Y_AXIS));
         mainPanel.add(makeTitlePanel());
 
-        settingsPane = new VerticalPanel();
+        JPanel settingsPane = new VerticalPanel();
         settingsPane.setBorder(margin2);
 
         graphPanel = new RespTimeGraphChart();



Mime
View raw message