jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1335125 - /jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
Date Mon, 07 May 2012 16:58:07 GMT
Author: pmouawad
Date: Mon May  7 16:58:06 2012
New Revision: 1335125

URL: http://svn.apache.org/viewvc?rev=1335125&view=rev
Log:
Bug 52266 - Code:Inconsistent synchronization 
Add synchronized on openFile method will not impact performance as method is private, lock
will be reentrant

Modified:
    jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java

Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java?rev=1335125&r1=1335124&r2=1335125&view=diff
==============================================================================
--- jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java (original)
+++ jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java Mon May  7
16:58:06 2012
@@ -136,7 +136,7 @@ public class StringFromFile extends Abst
         }
     }
     
-    private void openFile() {
+    private synchronized void openFile() {
         String tn = Thread.currentThread().getName();
         fileName = ((CompoundVariable) values[0]).execute();
 



Mime
View raw message