jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1210166 - in /jmeter/trunk/src/core/org/apache/jmeter: gui/GuiPackage.java testbeans/gui/TestBeanGUI.java
Date Sun, 04 Dec 2011 18:21:51 GMT
Author: pmouawad
Date: Sun Dec  4 18:21:51 2011
New Revision: 1210166

URL: http://svn.apache.org/viewvc?rev=1210166&view=rev
Log:
Bug 52279 - Switching to another language loses icons in Tree and logs error Can't obtain
GUI class from ...
Better fix after discussion on dev mailing list, thanks sebb for your review

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java?rev=1210166&r1=1210165&r2=1210166&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java Sun Dec  4 18:21:51 2011
@@ -362,10 +362,6 @@ public final class GuiPackage implements
             comp = testBeanGUIs.get(testClass);
             if (comp == null) {
                 comp = new TestBeanGUI(testClass);
-                // When Switching to another language occurs, Introspector clears its internal
caches
-                // and GUI classes information gets lost, so we initialize the GUI classes
here
-                // TODO Find a better place for this
-                ((TestBeanGUI)comp).setupGuiClasses();
                 testBeanGUIs.put(testClass, comp);
             }
         } else {

Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java?rev=1210166&r1=1210165&r2=1210166&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java Sun Dec  4 18:21:51
2011
@@ -475,6 +475,7 @@ public class TestBeanGUI extends Abstrac
 	public void localeChanged(LocaleChangeEvent event) {
 		try {
             beanInfo = Introspector.getBeanInfo(testBeanClass);
+            setupGuiClasses();
         } catch (IntrospectionException e) {
             log.error("Can't get beanInfo for " + testBeanClass.getName(), e);
             throw new Error(e.toString()); // Programming error. Don't



Mime
View raw message