jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1208828 - /jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java
Date Wed, 30 Nov 2011 22:03:47 GMT
Author: pmouawad
Date: Wed Nov 30 22:03:46 2011
New Revision: 1208828

URL: http://svn.apache.org/viewvc?rev=1208828&view=rev
Log:
Commented bugged unused code

Modified:
    jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java

Modified: jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java?rev=1208828&r1=1208827&r2=1208828&view=diff
==============================================================================
--- jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java (original)
+++ jmeter/trunk/src/reports/org/apache/jmeter/testelement/ReportPlan.java Wed Nov 30 22:03:46
2011
@@ -56,7 +56,7 @@ public class ReportPlan extends Abstract
 
     private static final List<String> itemsCanAdd = new LinkedList<String>();
 
-    private static ReportPlan plan;
+    //private static ReportPlan plan;
 
     // There's only 1 test plan, so can cache the mode here
     private static volatile boolean functionalMode = false;
@@ -113,17 +113,18 @@ public class ReportPlan extends Abstract
         getVariables().addArgument(name, value);
     }
 
-    public static ReportPlan createReportPlan(String name) {
-        if (plan == null) {
-            if (name == null) {
-                plan = new ReportPlan();
-            } else {
-                plan = new ReportPlan(name);
-            }
-            plan.setProperty(new StringProperty(TestElement.GUI_CLASS, "org.apache.jmeter.control.gui.ReportGui"));
-        }
-        return plan;
-    }
+    // FIXME Wrong code that create different constructor for static field depending on caller
+//    public static ReportPlan createReportPlan(String name) {
+//        if (plan == null) {
+//            if (name == null) {
+//                plan = new ReportPlan();
+//            } else {
+//                plan = new ReportPlan(name);
+//            }
+//            plan.setProperty(new StringProperty(TestElement.GUI_CLASS, "org.apache.jmeter.control.gui.ReportGui"));
+//        }
+//        return plan;
+//    }
 
     @Override
     public void addTestElement(TestElement tg) {



Mime
View raw message