incubator-ivy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin (JIRA)" <>
Subject [jira] Resolved: (IVY-650) add publish triggers to event system
Date Sat, 01 Dec 2007 02:32:43 GMT


Xavier Hanin resolved IVY-650.

       Resolution: Fixed
    Fix Version/s:     (was: unspecified)

I've integrated your patch in trunk here are some comments on your patch:
First of all, congratulations, this is the ideal contribution every open source developer
dream of: good code, good comments, very good tests and documentation. Wow!
Then some very minor things (to get improved for your next contribution :-)):
- we do not put @author tags in code, I've added your name in the contributors section of
the CHANGES.txt, it will also be in the RELEASE_NOTES of the beta 1.
- I had to add the license header in some new java files
- I had to format your code to meet our code style rules (that we don't fully respect for
historical reason, but try to clean our code as often as possible)

For the two last points, we have eclipse settings to take care of these things, I guess you
don't use eclipse. It's not really a problem, but if you are interested maybe you could share
your IDE settings, and see if there is a way to tell your IDE to put license headers and maybe
use a checkstyle plugin (if you plan to contribute again in the future).

Thanks again for this worthy contribution!

> add publish triggers to event system
> ------------------------------------
>                 Key: IVY-650
>                 URL:
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0
>            Reporter: Jason Trump
>            Assignee: Xavier Hanin
>            Priority: Minor
>             Fix For: 2.0.0-beta-1
>         Attachments: ivy-650.patch
> currently only download and resolve events are supported for triggers.  publish events
would facilitate customized updates to artifacts  (manifest files, jar signing, watermarking,
etc), as well as custom notification and logging.
> for consistency with the existing events, the new events should probably be:
> pre-publish-artifact
> post-publish-artifact
> with the following common attributes:
> organisation
> module
> revision
> artifact
> type
> ext
> resolver:    the name of the target resolver
> file:             the absolute path of the data file for the artifact
> overwrite:  whether the publication will overwrite existing resources
> post-publish-artifact will have an additional attribute:
> status:        'successful' or 'failed'
> indicating success or failure.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message