incubator-ivy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IVY-608) Add support for importing environment variables
Date Mon, 24 Sep 2007 12:51:50 GMT

    [ https://issues.apache.org/jira/browse/IVY-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529847
] 

Xavier Hanin commented on IVY-608:
----------------------------------

Reusing the code from Ant property task will bring quite a lot of code (which actually executes
an OS specific command), which we will have to maintain later. So I'm in favor of using Jing
solution, with a good documentation explaining that the feature is available for java5+ only.

About documentation, Jing could you provide a patch for the documentation too?

About the implementation, I think we should extract the code dealing with environment loading
in a separate class, and maybe even put it in a separate source directory, so that we could
still compile the core with jdk 1.4, and compile this class only with jdk 1.5+. Otherwise
we may easily introduce code relying on jdk5+ without noticing it.

> Add support for importing environment variables
> -----------------------------------------------
>
>                 Key: IVY-608
>                 URL: https://issues.apache.org/jira/browse/IVY-608
>             Project: Ivy
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: Jing Xue
>            Priority: Minor
>         Attachments: import-env-1.patch
>
>
> Ant supports importing environment variables into properties via the <properties environment="env"
/> task.  If an ivysettings.xml relies on an environment variable, the lack of support
for this feature in Ivy makes it difficult to reuse the same ivysettings.xml in a non-Ant
environment, such as in IvyDE.  I'm submitting a patch to add the support for JDK 1.5+. This
implementation will throw an exception when running in lesser JVMs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message