incubator-ivy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Williams (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IVY-383) LatestRevisionStrategy has split personality
Date Thu, 11 Jan 2007 15:24:27 GMT

    [ https://issues.apache.org/jira/browse/IVY-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463914
] 

John Williams commented on IVY-383:
-----------------------------------

I've added two patches that don't fix anything but they should help in making a fix.  IVY-383-testcase.patch
adds a unit test for this issue (currently failing, of course), and  IVY-383-LatestRevisionStrategy-argcheck.patch
adds some error checking that you may not want to check in, but I found it helpful in tracking
down problems.

> LatestRevisionStrategy has split personality
> --------------------------------------------
>
>                 Key: IVY-383
>                 URL: https://issues.apache.org/jira/browse/IVY-383
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.4.1
>         Environment: all
>            Reporter: John Williams
>            Priority: Critical
>         Attachments: IVY-383-LatestConflictManager.patch, IVY-383-LatestRevisionStrategy-argcheck.patch,
IVY-383-testcase.patch
>
>
> LatestRevisionStrategy seems to compare both revision numbers and revision number patterns,
but the implementation of patterns broken.  For instance, patterns like "1.0+" are treated
specially, but patterns like "[1.0,)" are treated like literal revision numbers!  I have a
case in which this causes conflict resolution to produce incorrect results.  I'll hopefully
be posting a patch soon to fix the particular resolution problem I've found, but I'm suspicious
that there are other cases in which patterns are erroneously passed to LatestRevisionStrategy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message