incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 陈明雨 <morning...@163.com>
Subject Re:Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03
Date Mon, 29 Mar 2021 02:47:56 GMT
Hi kezhenxu94:


Thanks for your apply.


We have such a scenario, such as the need to test a file decompression code in a unit test.
I think a reasonable way is to directly provide some small zip files for the unit test to
test the
decompression logic without writing a set of compression code to generate these zip files
at runtime.


And in fact, we also refer to the practices of some top-level projects, such as [1], [2].


In addition, I only found instructions on the Release that the main running code cannot contain
binary,
but the instructions for unit testing are rather vague, so we are not completely sure how
to deal with these problems reasonably.
If there are related links, could you please provide us for reference?


[1] https://github.com/apache/spark/tree/v3.1.1/sql/hive/src/test/resources/regression-test-SPARK-8489
[2] https://github.com/apache/impala/tree/3.4.0/testdata/tzdb




--

此致!Best Regards
陈明雨 Mingyu Chen

Email:
morningman@163.com;
morningman.cmy@gmail.com





在 2021-03-28 22:55:11,"kezhenxu94" <kezhenxu94@apache.org> 写道:
>
>
>> On Mar 28, 2021, at 18:40, 陈明雨 <morningman@163.com> wrote:
>> 
>> Hi kezhenxu94:
>> 
>> 
>> These files are for unit tests to test the java dynamic library loading, not some
kind of "test tools".
>
>I have some further questions, where are these files come from, if their source codes
are in the same repo, why not just build them from the source codes before using them, if
the files’ source codes are not in the same repo, there a bunch of ways to depend on them,
but including the binary files is not the first choice, if worse, the files’ source codes
are not accessible,  the PMC has no way to review the content and it’s a potential security
problem. 
>
>> These files are in the code repo for a long time and also contained in our previous
releases, and no one disagrees with it.
>> So I believe it is ok for a source release.
>
>The previous releases including them does not mean it’s ok IMO, it might be overlooked
, that’s one of the reasons why we need several releases before graduation to give the IPMC
more time to review the release process as well as their contents. 
>
>> 
>> 
>> 
>> --
>> 
>> 此致!Best Regards
>> 陈明雨 Mingyu Chen
>> 
>> Email:
>> chenmingyu@apache.org
>> 
>> 
>> 
>> 
>> 
>>> 在 2021-03-27 22:53:49,"kezhenxu94@apache" <kezhenxu94@apache.org> 写道:
>>> Sorry my -1, I saw there are binary files in the source tar, although they’re
test tools, but this is not allowed in the source release.
>>> 
>>> ./fe/fe-core/src/test/resources/plugin_test/plugin_test.jar
>>> ./fe/fe-core/src/test/resources/plugin_test/test_local_plugin/auditdemo.jar
>>> 
>>>>> On Mar 26, 2021, at 12:36, 寒江雪 <yangzhgg@gmail.com> wrote:
>>>> 
>>>> Hi all,
>>>> 
>>>> Please review and vote on Apache Doris 0.14.0-incubating-rc03 release.
>>>> 
>>>> Apache Doris is an MPP-based interactive SQL data warehousing for reporting
>>>> and analysis.
>>>> 
>>>> The Apache Doris community has voted on and approved this release:
>>>> https://lists.apache.org/thread.html/r1d3728b02b4f7b56413d3bf334b94fbc9c8406bf2d78aa01fea60a77%40%3Cdev.doris.apache.org%3E
>>>> 
>>>> The vote result email thread:
>>>> https://lists.apache.org/thread.html/re1eb419d0eb4689d77e82727811facef08f3c2498f64ad2ea812d42a%40%3Cdev.doris.apache.org%3E
>>>> 
>>>> The release candidate has been tagged in GitHub as 0.14.0-rc03, available
>>>> here:
>>>> https://github.com/apache/incubator-doris/releases/tag/0.14.0-rc03
>>>> 
>>>> Thanks to everyone who has contributed to this release, and there is a
>>>> simple release notes can be found here:
>>>> https://github.com/apache/incubator-doris/issues/5374
>>>> 
>>>> The artifacts (source, signature and checksum) corresponding to this release
>>>> candidate can be found here:
>>>> https://dist.apache.org/repos/dist/dev/incubator/doris/0.14/0.14.0-rc03/
>>>> 
>>>> This has been signed with PGP key 59F2ACED, corresponding to
>>>> yangzhg@apache.org.
>>>> KEYS file is available here:
>>>> https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
>>>> It is also listed here:
>>>> https://people.apache.org/keys/committer/yangzhg.asc
>>>> 
>>>> The vote will be open for at least 72 hours.
>>>> [ ] +1 Approve the release
>>>> [ ] +0 No opinion
>>>> [ ] -1 Do not release this package because ...
>>>> 
>>>> To verify and build, you can refer to following wiki:
>>>> https://github.com/apache/incubator-doris/wiki/How-to-verify-Apache-Release
>>>> https://wiki.apache.org/incubator/Incubator+Release+Checklist
>>>> 
>>>> You can also refer to instruction:
>>>> 
>>>> Firstly, you must be install and start docker service, and then you could
>>>> build Doris as following steps:
>>>> 
>>>> Step1: Pull the docker image with Doris building environment
>>>> $ docker pull apachedoris/doris-dev:build-env-1.2
>>>> You can check it by listing images, its IMAGE ID is d854b488afaf
>>>> 
>>>> Step2: Run the Docker image
>>>> You can run image directly:
>>>> $ docker run -it apachedoris/doris-dev:build-env1.2
>>>> 
>>>> Step3: Download Doris source
>>>> Now you should in the docker environment, and you can download the Doris
>>>> source package.
>>>> (If you have downloaded the source and it is not in image, you can map its
>>>> path to image in Step2.)
>>>> $ wget
>>>> https://dist.apache.org/repos/dist/dev/incubator/doris/0.14/0.14.0-rc03/apache-doris-0.14.0-incubating-src.tar.gz
>>>> 
>>>> Step4: Build Doris
>>>> Now you can decompress and enter Doris source path and build Doris.
>>>> $ tar zxvf apache-doris-0.14.0-incubating-src.tar.gz
>>>> $ cd apache-doris-0.14.0-incubating-src
>>>> $ sh build.sh
>>>> 
>>>> Best Regards,
>>>> Yang Zhengguo
>>> 
>>> 
>>> 
>>> ————————— 
>>> Zhenxu Ke (柯振旭)
>>> GitHub @kezhenxu94
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>For additional commands, e-mail: general-help@incubator.apache.org
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message