incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.3.1 (ROUND2)
Date Sun, 12 Jul 2020 01:24:26 GMT
Hi,

+1 (binding)

I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE is OK
- NOTICE has some minor issues (see below)
- All ASF file shave ASF headers
- Not unexpected binary files
- Can Compile from source

The NOTICE file in general should not contain license information as that belongs in LICENSE.
I see you copied all of the mybatis NOTICE file when it’s probably not needed. for instance
does your release contain OGNL? I don’t think there any reason to mention Spring Framework
in your NOTICE file as it has no NOTICE file.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message