incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache DataSketches-cpp 2.0.0-incubating-rc2
Date Fri, 22 May 2020 06:10:44 GMT
Hi,

+1 (binding)

I checked:
- incubating in name
- signatures and hashes are fine
- LICENSE and NOTICE good
- No unexpected binary files
- This file [1] is missing an ASF header an/or is of unknown license. I’m guessing it just
missing a header?
- Can compile from source

It might be a good idea to put the empty build directly in the source artefact to save the
use making it.

Thanks,
Justin

1. ./sampling/test/var_opt_union_test.cpp
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message