incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Furkan KAMACI <furkankam...@gmail.com>
Subject Re: [VOTE] Release Apache DataSketches-cpp 2.0.0-incubating-rc2
Date Tue, 19 May 2020 23:57:57 GMT
Hi,

+1 from me (binding, carrying over).

I checked:

- Incubating in name
- DISCLAIMER-WIP exists
- LICENSE and NOTICE are fine
- Checked PGP signatures
- Checked Checksums
- cmake, make, make test for cpp
- python wrapper build (tried with python3)

Kind Regards,
Furkan KAMACI

On Wed, May 20, 2020 at 2:47 AM Jon Malkin <jmalkin@apache.org> wrote:

> Hello IPMC and Apache DataSketches Community,
>
> 1. This is a call for vote to release Apache DataSketches-cpp version:
> 2.0.0-incubating-rc2
>
>     NOTE 1: The C++ code provides a header-only library. Compilation
> is needed only to build unit tests. A Python extension is also
> included in this repository as a set of thin wrappers. That does
> produce a compiled artifact, but is not built by default.
>
>     NOTE 2: Compiling the C++ unit tests requires CMake 3.12 or newer.
>
>     NOTE 3: During the release process, we discovered one unit test
> file (sampling/test/var_opt_union_test.cpp) missing a copyright
> header.
>
>
>   A. Results from the PPMC vote:
>
>      - 1 (+1 binding) vote, 2 (+1 non-binding) votes
>
>      - The vote thread can be found at the Permalink:
>
> https://lists.apache.org/thread.html/rf34f3bc1ca54d5fcec3fa88a18ef7005312f54bf7e7e9671ffdadbee%40%3Cdev.datasketches.apache.org%3E
>
>   B. Testing/actions/votes performed by the voters in the PPMC Stage 1:
>
>     - Alexander Saydakov (+1 non-binding)
>       Checked:
>       - gpg signature
>       - shasum
>       - cmake, make, make test
>       - python wrapper build: had to specify python3 explicitly and sudo
> install
>       - tried using CPC sketch in python environment
>
>     - Lee Rhodes (+1 non-binding)
>       Checked:
>       - gpg signature
>       - shasum
>       - cmake, make, make test
>       - Confirmed Licenses in LICENSE file are still relevant.
>       - NOTICE and DISCLAIMER-WIP look good.
>       - minor formatting problems in README.md:
>         The file has some tabs, which should be replaced by 4-spaces.
>         Line 25 needs 4 leading spaces not 2; this messes up the rendering
> of
>         that section.
>
>     - Furkan Kamachi (+1 binding)
>       I checked:
>       - Incubating in name
>       - DISCLAIMER-WIP exists
>       - LICENSE and NOTICE are fine
>       - Checked PGP signatures
>       - Checked Checksums
>       - cmake, make, make test for cpp
>       - python wrapper build (tried with python3)
>
> 2. Source repository:
>     - https://github.com/apache/incubator-datasketches-cpp
>
>     Git Tag for this release:
>     -
> https://github.com/apache/incubator-datasketches-cpp/tree/2.0.0-incubating-rc2
> on branch 2.0.x-incubating
>
>     Git HashId for this release starts with: c51298d
>
> 3. The Release Candidate / Dist (Zip Repository):
>     -
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/2.0.0-incubating-rc2/
>
>     The public signing key can be found in the KEYS file:
>     - https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
>     The artifacts have been signed with --keyid-format SHORT : 38F334CC
>
> 4. C++ Test Guide:
>     -
> https://github.com/apache/incubator-datasketches-cpp/blob/2.0.0-incubating-rc2/README.md
> 5. Python Build & Test Guide:
>     -
> https://github.com/apache/incubator-datasketches-cpp/blob/2.0.0-incubating-rc2/python/README.md
>     - Most python unit tests are written in a tutorial style that can
> be followed as example usage:
>
> https://github.com/apache/incubator-datasketches-cpp/tree/2.0.0-incubating-rc2/python/tests
>     - Only python 3 is supported
>
> 6. This is the second stage vote:
>    - This voting process will remain open for at least 72 hours and
> until at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> Thanks,
> Jon Malkinjmalkin@apache.org <http://jmalkinapache.org>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message