incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leerho <lee...@gmail.com>
Subject Re: [VOTE] Release Apache DataSketches-java 1.3.0-incubating-RC1
Date Sat, 02 May 2020 16:43:59 GMT
Hi Justin,
Thank you for your vote:

NOTICE is a little odd with Verizon Media copyright line


What do you find "odd"?

The are some .bin files in the test resources that like like they may be
> compiled code. Is there a  way to generate these from source code?


Those bin files are not compiled source code but are representative binary
output images of sketch data structures that fall into one of 2 cases:

   - Sketch images produced by C++.  This allows us to validate
   cross-language binary compatibility.
   - Sketch images produced by earlier versions of the source code.  This
   allows to to validate forward compatibility.

We have certainly talked about ways to eliminate these binaries, but have
yet to come up with a solution that would be efficient and effective.

Lee.

On Fri, May 1, 2020 at 11:30 PM Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in name
> - signatures and hashes are fine
> - disclaimer exists
> - LICENSE is fine
> - NOTICE is a little odd with Verizon Media copyright line
> - The are some .bin files in the test resources that like like they may be
> compiled code. Is there a  way to generate these from source code?
> - All ASF file have ASF headers
> - Can compile from source
>
> Thanks,
> Justin
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message