incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
Date Sat, 02 May 2020 06:01:24 GMT
HI,

I know the vote has all ready passed but I can see a  couple of issues here:
- LICENSE is missing the appendix
- As noted the NOTICE is not correct. License are not lined in NOTICE they are licensed in
LICENSE and need to be the full text. Dependancies don’t need to be listed only that that
are bundled in the release.
- The release included what looks like to be compiled code, this is generally not allowed
in a source release [1]
- LICENSE is missing the license of this file [2]

Thanks,
Justin

1. ./src/main/resources/opennlp/*.bin
2. https://github.com/peet/hashids.java/blob/master/src/HashidsJava/Hashids.java


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message