incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Apache Tuweni 1.0.0-incubating release
Date Sun, 15 Mar 2020 07:37:14 GMT
Hi,

+1 (binding)

I checked only the source release:
- incubating in name
- signature and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE are good
- No unexpected binary files
- Hard to tell if any files are missing headers due to large number of Json files
- Didn’t compile from source

It a little unclear from the names if if gossip and relayer are binary or source artefacts,
you might want to correct that.

Also you might want consider  removing the large amount of test resource form the source release,
IMO users generally want to build the release not test it ands it on the rather large size
with some test file being over 1Mb.

Thanks,
Justin



---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message