incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Fisher <w...@apache.org>
Subject Re: [VOTE] Heron 0.20.2-incubating Release Candidate 1
Date Thu, 14 Nov 2019 17:41:23 GMT
Hi -

I failed on Catalina as well. It was in bazel_configure.py due to Xcode now identifies as:

FAILED:  Could not determine the version of /usr/bin/clang from the following output
/usr/bin/clang --version
Apple clang version 11.0.0 (clang-1100.0.33.12)
Target: x86_64-apple-darwin19.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

bazel_configure.py needs to be updated for Heron’s next release.

Regards,
Dave

> On Nov 14, 2019, at 9:32 AM, Furkan KAMACI <furkankamaci@gmail.com> wrote:
> 
> Hi,
> 
> Babel info is as follows:
> 
> brew info bazel
> bazel: stable 1.1.0 (bottled)
> Google's own build tool
> https://bazel.build/
> /usr/local/Cellar/bazel/1.1.0 (11 files, 25.8MB) *
>  Poured from bottle on 2019-11-14 at 18:07:21
> From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/bazel.rb
> ==> Dependencies
> Build: python ✘
> ==> Requirements
> Required: java = 1.8 ✔, macOS >= 10.10 ✔
> ==> Caveats
> Bash completion has been installed to:
>  /usr/local/etc/bash_completion.d
> 
> zsh completions have been installed to:
>  /usr/local/share/zsh/site-functions
> ==> Analytics
> install: 5,884 (30 days), 16,836 (90 days), 74,584 (365 days)
> install_on_request: 5,490 (30 days), 15,659 (90 days), 68,636 (365 days)
> build_error: 0 (30 days)
> 
> Kind Regards,
> Furkan KAMACI
> 
> On Thu, Nov 14, 2019 at 8:27 PM Josh Fischer <josh@joshfischer.io> wrote:
> 
>> Ning,
>> 
>> The current Travis CI script runs with Bazel 0.26.0.
>> 
>> On Thu, Nov 14, 2019 at 11:13 AM Ning Wang <wangninggm@gmail.com> wrote:
>> 
>>> Which version of bazel you are using? Heron is using 0.26.1 current.
>>> 
>>> Mac dev environment could be another possibility. XCode tool chain seems
>> to
>>> have some changes causing some rules to fail and maybe the new MacOS has
>>> these changes by default. I have been using docker to build after
>>> installing the latest XCode.... Definitely something we should look into.
>>> 
>>> Thanks for the feedback!
>>> 
>>> On Thu, Nov 14, 2019 at 7:19 AM Furkan KAMACI <furkankamaci@gmail.com>
>>> wrote:
>>> 
>>>> Hi,
>>>> 
>>>> +1 from me.
>>>> 
>>>> I checked:
>>>> - Incubating in name
>>>> - DISCLAIMER exists
>>>> - LICENSE and NOTICE are fine
>>>> - No unexpected binary files
>>>> - Checked PGP signatures
>>>> - Checked Checksums
>>>> 
>>>> PS 1: Justin's objections should be resolved.
>>>> 
>>>> PS 2: I couldn't compile the source code at my MacOSX Catalina
>> following
>>>> this tutorial:
>>>> 
>> https://apache.github.io/incubator-heron/docs/developers/compiling/mac/.
>>>> 
>>>> Could you explain it whether there are checkstyle errors or more? Error
>>> is
>>>> below:
>>>> 
>>>> ERROR:
>>>> 
>>>> 
>>> 
>> /private/var/tmp/_bazel_kamaci/625cc18c0e4b9bd1bb57e5abdd5a955a/external/com_google_protobuf/protobuf.bzl:130:19:
>>>> Traceback (most recent call last):
>>>> File
>>>> 
>>>> 
>>> 
>> "/private/var/tmp/_bazel_kamaci/625cc18c0e4b9bd1bb57e5abdd5a955a/external/com_google_protobuf/protobuf.bzl",
>>>> line 125
>>>> rule(<3 more arguments>)
>>>> File
>>>> 
>>>> 
>>> 
>> "/private/var/tmp/_bazel_kamaci/625cc18c0e4b9bd1bb57e5abdd5a955a/external/com_google_protobuf/protobuf.bzl",
>>>> line 130, in rule
>>>> attr.label(cfg = "host", <3 more arguments>)
>>>> 'single_file' is no longer supported. use allow_single_file instead.
>> You
>>>> can use --incompatible_disable_deprecated_attr_params=false to
>>> temporarily
>>>> disable this check.
>>>> ERROR:
>>>> 
>>>> 
>>> 
>> /Users/kamaci/incubator-heron-0.20.2-incubating-rc1/tools/java/src/org/apache/bazel/checkstyle/BUILD:36:1:
>>>> error loading package '@com_google_protobuf//': Extension file
>>>> 'protobuf.bzl' has errors and referenced by
>>>> '//tools/java/src/org/apache/bazel/checkstyle:util'
>>>> ERROR: Analysis of target '//heron/shell/assets:assets' failed; build
>>>> aborted: error loading package '@com_google_protobuf//': Extension file
>>>> 'protobuf.bzl' has errors
>>>> INFO: Elapsed time: 105.248s
>>>> INFO: 0 processes.
>>>> FAILED: Build did NOT complete successfully (142 packages loaded, 489
>>>> targets configured)
>>>> 
>>>> Kind Regards,
>>>> Furkan KAMACI
>>>> 
>>>> On Thu, Nov 14, 2019 at 4:50 PM Josh Fischer <josh@joshfischer.io>
>>> wrote:
>>>> 
>>>>> Hi all,
>>>>> 
>>>>> We have one binding vote so far.  Does anyone have the time to vote
>> on
>>>> this
>>>>> release?
>>>>> 
>>>>> - Josh
>>>>> 
>>>>> On Sun, Nov 10, 2019 at 2:42 PM Justin Mclean <
>>> justin@classsoftware.com>
>>>>> wrote:
>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> +1 (binding)
>>>>>> 
>>>>>> Thanks for fixing teh issues raised last time.
>>>>>> 
>>>>>> I checked:
>>>>>> - incubating in name
>>>>>> - signatures and hashes are file
>>>>>> - DISCLAIMER exists
>>>>>> - LICENSE is OK. It would be god to see local links to the licenses
>>> as
>>>>>> URLs content may change or they may die over time.
>>>>>> - NOTICE is fine
>>>>>> - All source files have ASF headers where needed
>>>>>> - No unexpected binary files
>>>>>> - I didn’t try compiling
>>>>>> 
>>>>>> For LICENSE:
>>>>>> - JQuery is incorrectly listed as ALv2 it’s MIT licensed
>>>>>> - JSXTransformer is also listed as ALv2 and is actually MIT
>> licensed
>>>>>> 
>>>>>> For all BSD and MIT you need to include the full text of the
>> license.
>>>> It
>>>>>> seems you are missing some license(s) for file that don’t include
>> the
>>>>>> header and are missing from the licenses directory e.g.
>>>> JSXTransformer. I
>>>>>> did not check them all.
>>>>>> 
>>>>>> Thanks,
>>>>>> Justin
>>>>>> 
>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>>> 
>>>>>> --
>>>>> Sent from A Mobile Device
>>>>> 
>>>> 
>>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message