incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YiZhi Liu <eazhi....@gmail.com>
Subject Re: Help Verify Apache(incubating) TVM Release RC
Date Sat, 23 Nov 2019 22:54:21 GMT
Thanks Justin for helping, we'll make modification accordingly.

On Sat, Nov 23, 2019 at 2:15 PM Justin Mclean <justin@classsoftware.com> wrote:
>
> Hi,
>
> I checked the release candidate further:
> - Signatures and hashes good
> - DISCLAIMER exists
> - LICENSE is missing a few things
> - NOTICE needs some minor adjustments
> - Some files are missing ASF headers e.g. [1][2][3][4][5] (+ others)
> - Some files incorrectly have an ASF headers or have ASF lines with a unneeded copyright
line. e.g [6][7][8][9][10][11] and many many other files.
> - No unexpected binary files
>
> You'll need to remove all "Copyright (c) XXXX by Contributors” where the files were
donated to the ASF (and there’s signed ICLAS for everyone that worked on that file) so it
clear what is a 3rd party file and what is not.
>
> Because of the above issue it impossible to work out what is missing in  LICENCE, this
will be a subset:
> - Code zlib licensed in  [6]
> - BSD code in [9] (this is not ALv2 likened as mentioned the LICENSE file)
> - ASv2 licensed code in [11]
> - BSD code in [12]
>
> In NOTICE is incorrect to say “2017 and onwards”, it should just be 2019.
>
> Thanks,
> Justin
>
> 1. ./nnvm/tests/cpp/unittest.mk
> 2. ./nnvm/make/config.mk
> 3. ./ docs/_static/css/tvm_theme.css
> 4. apps/android_rpc/app/src/main/jni/Android.mk
> 5. apps/ios_rpc/tvmrpc/Base.lproj/LaunchScreen.storyboard
> 6. /nnvm/include/nnvm/op.h
> 7. ./src/schedule/bound.cc
> 8. ./src/schedule/bound.cc
> 9.  vi ./3rdparty/picojson/picojson.h
> 10. ./vta/src/de10nano/cma_api.cc
> 11. /3rdparty/compiler-rt/builtin_fp16.h
> 12. ./3rdparty/dmlc-core/include/dmlc/concurrentqueue.h
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tvm.apache.org
> For additional commands, e-mail: dev-help@tvm.apache.org
>


-- 
Yizhi Liu

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message