incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3
Date Thu, 21 Nov 2019 00:48:04 GMT
Hi,

+1 (binding)

In the source release I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE and NOTICE fine
- all files have ASF headers
- no unexpected binary files
- can compile from source 

A couple of suggestions:
- You might want to add a link the ASF code of conduct in your code of conduct.
- You might want to update your version of the Mavin wrapper to be the latest.
- Something been to have gone wrong with the footer in [1] where is says "Copyright © The
Apache Software Foundation, Licensed under the Apache License, Version 4.0.0-RC3”. Do you
mean Apache License version 2?

Thanks,
Justin

1. ./sharding-ui/sharding-ui-frontend/src/components/Footer/index.vue
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message