incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Heron 0.20.2-incubating Release Candidate 1
Date Sun, 10 Nov 2019 20:42:35 GMT
Hi,

+1 (binding)

Thanks for fixing teh issues raised last time.

I checked:
- incubating in name
- signatures and hashes are file
- DISCLAIMER exists
- LICENSE is OK. It would be god to see local links to the licenses as URLs content may change
or they may die over time.
- NOTICE is fine
- All source files have ASF headers where needed
- No unexpected binary files
- I didn’t try compiling

For LICENSE:
- JQuery is incorrectly listed as ALv2 it’s MIT licensed
- JSXTransformer is also listed as ALv2 and is actually MIT licensed

For all BSD and MIT you need to include the full text of the license. It seems you are missing
some license(s) for file that don’t include the header and are missing from the licenses
directory e.g. JSXTransformer. I did not check them all.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message