incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Pan" <panj...@apache.org>
Subject Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3
Date Thu, 21 Nov 2019 05:05:53 GMT
Hi Justin,


Very appreciated your detailed checking.


An issue[1] based on your suggestions was created and would be done before next release. 


> You might want to add a link the ASF code of conduct in your code of conduct.
A link of the ASF code of conduct has been added to our code of conduct page [2]. However,
i also want to plead you to confirm whether this link[3] is what you mentioned. 


Thanks.


[1] https://github.com/apache/incubator-shardingsphere/issues/3566
[2] https://shardingsphere.apache.org/community/en/contribute/code-conduct
[3] https://www.apache.org/foundation/policies/conduct.html


 Juan Pan


panjuan@apache.org
Juan Pan(Trista), Apache ShardingSphere


On 11/21/2019 08:48,Justin Mclean<justin@classsoftware.com> wrote:
Hi,

+1 (binding)

In the source release I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE and NOTICE fine
- all files have ASF headers
- no unexpected binary files
- can compile from source

A couple of suggestions:
- You might want to add a link the ASF code of conduct in your code of conduct.
- You might want to update your version of the Mavin wrapper to be the latest.
- Something been to have gone wrong with the footer in [1] where is says "Copyright © The
Apache Software Foundation, Licensed under the Apache License, Version 4.0.0-RC3”. Do you
mean Apache License version 2?

Thanks,
Justin

1. ./sharding-ui/sharding-ui-frontend/src/components/Footer/index.vue
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message