incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leerho <lee...@gmail.com>
Subject Re: [VOTE] Release DataSketches-java 1.1.0-incubating-RC1
Date Wed, 02 Oct 2019 16:28:38 GMT
Justin,

Thank you for your vote and comments.  Your suggestions for the NOTICE file
have already been incorporated in master going forward.

Please inspect it at
https://github.com/apache/incubator-datasketches-java/blob/master/NOTICE to
see if there are any other changes that you would like to make.

Lee.


On Tue, Oct 1, 2019 at 6:07 PM Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +1 binding
>
> I checked:
> - incubating in name
> - signature and hashes correct
> - LICENSE is OK
> - NOTICE has minor issues
> - no unexpected binary files
> - all source file have ASF headers
> - can compile from source
>
> One minor thing with the NOTICE it’s not correct to say "2019 - Present”,
> copyright applies when a work is published and doesn’t last forever. I’d
> also (as suggested before on the last release) put the ASF copyright first.
>
> Also these two statement seem to possibly contradict each other:
> Copyright 2018 - Present, Verizon
> Copyright 2019 - Present, The Apache Software Foundation
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message