incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release DataSketches-java 1.1.0-incubating-RC1
Date Wed, 02 Oct 2019 00:49:20 GMT
Hi,

+1 binding

I checked:
- incubating in name
- signature and hashes correct
- LICENSE is OK
- NOTICE has minor issues
- no unexpected binary files
- all source file have ASF headers
- can compile from source

One minor thing with the NOTICE it’s not correct to say "2019 - Present”, copyright applies
when a work is published and doesn’t last forever. I’d also (as suggested before on the
last release) put the ASF copyright first.

Also these two statement seem to possibly contradict each other:
Copyright 2018 - Present, Verizon
Copyright 2019 - Present, The Apache Software Foundation

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message