incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leerho <lee...@gmail.com>
Subject Re: [VOTE] DataSketches-memory RC2
Date Thu, 01 Aug 2019 20:56:38 GMT
Ted,

I upgraded Maven to 3.6.1 -- now I see the warning above.
I think I understand, after some research..., the new Maven doesn't like
the <prerequisites>...</prerequisites> style of specifying what Maven to
use, it want us to use the Maven enforcer plugin instead.  Jeez, the error
message could have just said that.

On Thu, Aug 1, 2019 at 1:01 PM leerho <leerho@gmail.com> wrote:

> Thank you  Furkan KAMACI, Greg Stein, and Ted Dunning.  You all responded
> within a one hour window!
>
> Ted,
>
> [*WARNING*] The
>> project org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating
>> uses
>> prerequisites which is only intended for maven-plugin projects but not
>> for non maven-plugin projects.
>> For such purposes you should use the maven-enforcer-plugin. See
>> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
>
>
> I have never seen this warning.
>   Which prerequisite is it complaining about?  What exactly is the
> conflict?
>   The link points to a Require Maven Version rule.
>   I am using Maven 3.3.9.
>   The pom specifies a prerequisite of Maven 3.0.4, which I assume means a
> minimum of 3.0.4.  Is this not an enforcement?
>   It appears you are using Maven 3.6.1.
>   Is it a problem to be running a newer version of maven than 3.0.4 ?
>   Do we need to "enforce" the Maven version as long as it is > 3.0.4 ?
>   How can I reproduce this warning?  (run a new version of Maven ?? )
>
> The maven-compiler-plugin is configured to use java version 1.8 for both
> source and target.
> Apparently, you are saying that this configuration is not being enforced
> when you ran  mvn clean test!
>
> Clearly, if this is the case, we need the enforcer plugin for the JVM
> version!
>
> This is an eye-opener for me. Thank you for catching this!
>
> Lee.
>
>
>
>
>
>
>
>
>
>
>
>
> On Thu, Aug 1, 2019 at 11:54 AM Ted Dunning <ted.dunning@gmail.com> wrote:
>
>> +1 (binding)
>>
>> As a side comment, I know that you said it in your second email, but the
>> restriction to *exactly* java 1.8 isn't clear from the README. Also, it is
>> easy to *think* you have changed which version of java you are using, but
>> not actually have done so. For an example of how this illusion can play
>> out, see below.
>>
>> It would be good if you could actually detect the version mismatch and
>> fail
>> early with a coherent message. This can be done with the enforcer plugin
>> (see
>> https://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html
>> )
>>
>> $ java -version
>>
>> openjdk version "1.8.0_222"
>>
>> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10)
>>
>> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode)
>>
>>
>> $ javac -version
>>
>> javac 1.8.0_222
>>
>>
>> $ mvn clean test
>>
>> [*INFO*] Scanning for projects...
>>
>> [*WARNING*] The project
>> org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating uses
>> prerequisites which is only intended for maven-plugin projects but not for
>> non maven-plugin projects. For such purposes you should use the
>> maven-enforcer-plugin. See
>> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
>>
>> [*INFO*]
>>
>> ...
>>
>> [*INFO*] -------------------------------------------------------------
>>
>> [*WARNING*] COMPILATION WARNING :
>>
>> [*INFO*] -------------------------------------------------------------
>>
>> [*WARNING*]
>>
>> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/UnsafeUtil.java:[25,16]
>> sun.misc.Unsafe is internal proprietary API and may be removed in a future
>> release
>>
>> [*WARNING*]
>>
>> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirectMap.java:[37,18]
>> sun.nio.ch.FileChannelImpl is internal proprietary API and may be removed
>> in a future release
>>
>> ...
>>
>> [*INFO*] 8 warnings
>>
>> [*INFO*] -------------------------------------------------------------
>>
>> [*INFO*] -------------------------------------------------------------
>>
>> [*ERROR*] COMPILATION ERROR :
>>
>> [*INFO*] -------------------------------------------------------------
>>
>> [*ERROR*]
>>
>> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[27,16]
>> cannot find symbol
>>
>>   symbol:   class Cleaner
>>
>>   location: package sun.misc
>>
>> [*ERROR*]
>>
>> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[39,17]
>> cannot find symbol
>>
>>   symbol:   class Cleaner
>>
>>   location: class ...
>>
>> [*INFO*] 6 errors
>>
>> [*INFO*] -------------------------------------------------------------
>>
>> [*INFO*]
>> *------------------------------------------------------------------------*
>>
>> [*INFO*] *BUILD FAILURE*
>>
>> [*INFO*]
>> *------------------------------------------------------------------------*
>>
>> [*INFO*] Total time:  3.676 s
>>
>> [*INFO*] Finished at: 2019-08-01T11:44:50-07:00
>>
>> ...
>>
>> $
>>
>>
>> The problem is that maven is ignoring all efforts to specify a different
>> JDK, of course, as shown here:
>>
>> $ mvn -version
>>
>> *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
>> 2019-04-04T12:00:29-07:00)*
>>
>> Maven home: /usr/local/Cellar/maven/3.6.1/libexec
>>
>> Java version: 12.0.2, vendor: AdoptOpenJDK, runtime:
>> /Library/Java/JavaVirtualMachines/adoptopenjdk-12.0.2.jdk/Contents/Home
>>
>> Default locale: en_US, platform encoding: UTF-8
>>
>> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
>>
>>
>>
>> On Thu, Aug 1, 2019 at 10:59 AM Greg Stein <gstein@gmail.com> wrote:
>>
>> > +1 (binding)
>> >
>> >
>> > On Mon, Jul 29, 2019 at 12:09 AM leerho <leerho@gmail.com> wrote:
>> >
>> > > Hello Apache general@incubator community.
>> > >
>> > > 1. This is a call for vote to release Apache DataSketches-memory
>> version:
>> > >  1.0.0-incubating-RC2
>> > >
>> > > NOTE 1: This is one component of the DataSketches library which needs
>> to
>> > be
>> > > released first as other repositories have a dependency on this one.
>> Once
>> > > this is released, the other components of the library will be able to
>> be
>> > > released.
>> > >
>> > >
>> > > 2. Results from the PPMC vote (open for more than 102 hours not
>> counting
>> > > the weekend)
>> > >
>> > >   - 5 votes were cast. All of the votes were (+1). Two of the votes
>> were
>> > > from Mentors.
>> > >
>> > >   - The vote thread can be found at:
>> > >
>> > >
>> >
>> https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser
>> > >
>> > >
>> > > 3. Testing/actions/votes performed by the voters:
>> > >
>> > >   - Lee Rhodes: (+1)
>> > >     - All of the code has been properly refactored with
>> > > "org.apache.datasketches...".
>> > >     - All source files have the proper Apache license and have been
>> > checked
>> > > with the Maven Rat Plugin.
>> > >     - The code passes all tests with a coverage of > 98%.
>> > >     - Checkstyle: passes with no warnings.  This uses the
>> configuration
>> > > MemoryCheckstyle.xml located in the /tools/ directory.
>> > >     - SpotBugs: passes with no bugs found: This uses the configuration
>> > > FindBugsExcludeFilter.xml located in the /tools/directory.
>> > >     - mvn clean javadoc:javadoc produces no javadoc errors.  The
>> javadocs
>> > > will be found under /target/site/
>> > >     - mvn versions:display-plugin-updates.  This has 2 warnings, but
>> the
>> > > versions are inherited from the super-pom.
>> > >        - [WARNING] The following plugins do not have their version
>> > > specified:
>> > >        - [WARNING] maven-assembly-plugin ..................... (from
>> > > super-pom) 2.6
>> > >        - [WARNING] maven-compiler-plugin ..................... (from
>> > > super-pom) 3.5.
>> > >        Note: In the next release we can add the version numbers to the
>> > > local pom to eliminate this warning.
>> > >     - The assembly file signatures and checksums have been verified.
>> > >
>> > >   - Alex Saydakov: (+1)
>> > >     - mvn package
>> > >     - mvn test
>> > >
>> > >   - Jon Malkin: (+1)
>> > >     - mvn test
>> > >     - mvn install
>> > >
>> > >   - Furkan Kamaci (+1 IPMC Member)
>> > >     - incubating in name
>> > >     - Disclamer exists
>> > >     - License is fine
>> > >     - Notice is fine
>> > >     - no unexpected binary files
>> > >     - code compiles and tests successfully run
>> > >
>> > >   - Kenneth Knowles (+1 IPMC Member)
>> > >     Double checked:
>> > >       - DISCLAIMER, LICENSE and NOTICE
>> > >       - mvn install succeeded
>> > >
>> > >
>> > > 4. Source repository:
>> > > https://github.com/apache/incubator-datasketches-memory
>> > >
>> > >   - Git Tag for this release: 1.0.0-incubating-RC2
>> > >
>> > >
>> > >
>> >
>> https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC2
>> > >
>> > >   - Git HashId for this release starts with: ec8f16e
>> > >
>> > >
>> > > 5. DIST/DEV: The release candidate assembly:
>> > >
>> > >   -
>> > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC2/apache-datasketches-memory-1.0.0-incubating-src.zip
>> > >
>> > >   - The assembly file has been signed with --keyid-format SHORT :
>> > 8CD4A902
>> > >
>> > >   - The public signing key can be found in the KEYS file:
>> > >
>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>> > >
>> > >   - Upon acceptance, the above assembly and signatures will be
>> deployed
>> > > into the official Apache release repository:
>> > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/
>> > >
>> > >
>> > > 6. NEXUS: The Jar and pom attributes have been deployed to Nexus
>> Staging
>> > > Repository "orgapachedatasketches-1000", which can be examined from
>> the
>> > > Nexus UI.
>> > >
>> > >    - Upon acceptance, the staging repository holding the artifacts
>> will
>> > be
>> > > closed and then the artifacts will be released.
>> > >
>> > >
>> > > 7. Note that Mentors kenn@apache.org and furkankamaci@gmail.com as
>> well
>> > as
>> > > paulk@asert.com.au have made a number of valuable suggestions on
>> > improving
>> > > the process that are recorded in a separate thread.  None of the
>> > > suggestions impact the voting for this release. This has been valuable
>> > > learning for us and we will be implementing these suggestions in the
>> next
>> > > release.
>> > >
>> > > Lee
>> > > leerho@apache.org
>> > >
>> >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message