incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Furkan KAMACI <furkankam...@gmail.com>
Subject Re: [VOTE] Release Apache Druid (incubating) 0.14.2 [RC1]
Date Thu, 23 May 2019 23:15:08 GMT
Hi,

+1 (binding)

- Can compile the code
- LICENSE, DISCLAIMER, NOTICE are OK.
- ASF Headers are OK

Kind Regards,
Furkan KAMACI

On Fri, May 24, 2019 at 2:09 AM Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in name
> - signatures and license correct
> - DISCLAIMER exists
> - LICENSE and NOTCE ok
> - all source file have ASF headers
> - no unexpected binary files (but see below)
> - can compile from source
>
> There is one minor license issue jquery 1.11.1 includes MIT licensed
> sizzle.js and that should be mentioned in LICENSE.
>
> I not you included a minified version of jquery in the releasee, some
> people consider this to be to compiled code and not allowed in a source
> release. You might want to consider changing this and/or adding the
> un-minified version so it's contents are clearer. This also hid the minor
> LICENSE issue mentioned above.
>
> If anyone is wondering how I found this I just know it from looking at
> previous releases containing jQuery.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message