incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sheng Zha <szha....@gmail.com>
Subject Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2
Date Wed, 13 Feb 2019 04:47:24 GMT
Hi Vinay,

Thank you for the pointer. I will apply the same header in mxnet markdown
files.

While I fully intend to uphold incubator MXNet's release to the standard of
Apache, I'm curious why some TLPs adopt this while others don't. In this
case, is this still a requirement and a basis for stopping a release? Many
people put in hard work to make it happen so I hope to bring good answers
to them.

-sz

On Tue, Feb 12, 2019 at 8:27 PM Vinayakumar B <vinayakumarb@apache.org>
wrote:

> Hi Sheng Zha,
>
> Check example from Hadoop's documentation.
>
> https://raw.githubusercontent.com/apache/hadoop/trunk/hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md
>
> In Hadoop's documentation all markdown files have header and none of them
> are excluded from RAT check.
> -Vinay
>
>
> On Wed, Feb 13, 2019 at 9:34 AM Sheng Zha <zhasheng@apache.org> wrote:
>
> > Also, I looked to the TLP Apache Spark for an example on license header
> on
> > markdown, and I found none [1].
> >
> > Is your comment on markdown file a suggestion or a requirement? Some
> > clarification would be much appreciated.
> >
> > -sz
> >
> > [1]
> >
> https://github.com/apache/spark/search?q=Licensed+to+the+Apache+Software+Foundation&unscoped_q=Licensed+to+the+Apache+Software+Foundation
> >
> >
> > On 2019/02/13 03:49:49, Sheng Zha <zhasheng@apache.org> wrote:
> > > Hi Luciano,
> > >
> > > Thank you for the helpful feedback. As a PPMC member of Apache MXNet,
> > I'd like to resolve this issue once for all. One thing that we can
> benefit
> > from your help is narrowing down what file types are acceptable to be in
> > whitelist.
> > >
> > > I started a pull-request for this purpose [1] (and thread [2]). Given
> > that RAT check is a popular method at Apache, I'd appreciate you and
> other
> > people who are willing to help to comment on it. If others find it
> useful,
> > I'm happy to bring back the result to the list once we have clarity.
> > >
> > > -sz
> > >
> > > [1] https://github.com/apache/incubator-mxnet/pull/14142
> > > [2]
> >
> https://lists.apache.org/thread.html/7edb466510963e1c9f2c7b3bf35b7c6a8b0dac83bfa520113b34cea3@%3Ccommits.mxnet.apache.org%3E
> > >
> > > On 2019/02/12 04:51:01, Luciano Resende <luckbr1975@gmail.com> wrote:
> > > > On Mon, Feb 11, 2019 at 3:55 PM Hen <bayard@apache.org> wrote:
> > > > >
> > > > > Did you mean:
> > > > >
> > > > > "The rat-exclude configuration on the project _must_ be less
> > permissive."
> > > > >
> > > > > ?
> > > > >
> > > >
> > > > What I was trying to say is that, even though MXNet has configured
> and
> > > > is using rat, the rat-exclude then is very broad, where it excludes
> > > > like (*.xml which leave pom.xml out for example, or docker/*) this
> > > > causes a lot of files that can ahd must have apache license headers
> to
> > > > not be checked.
> > > >
> > > > > (your text suggests it's an option, whereas your vote says it's
> > required)
> > > > >
> > > >
> > > > https://www.apache.org/legal/src-headers.html
> > > >
> > > > > On Sun, Feb 10, 2019 at 8:08 PM Luciano Resende <
> > luckbr1975@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > I ran RAT, and while I understand that a lot of the failures
are
> > > > > > coming from the 3rdparty directory, some of those are from files
> > that
> > > > > > should have the ASF license header such as pom files, docker
> files,
> > > > > > project documentation (yes, MD files do accept apache license
> > > > > > headers),  Maybe the rat-exclude configuration on the project
> > should
> > > > > > be less permissive.
> > > > > >
> > > > > > Based on this I am -1 (binding)
> > > > > >
> > > > > > On Wed, Feb 6, 2019 at 1:59 PM Steffen Rochel <
> > steffenrochel@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > Dear community,
> > > > > > >
> > > > > > > This is a call for releasing Apache MXNet (incubating)
1.4.0,
> > release
> > > > > > > candidate 2
> > > > > > >
> > > > > > > Apache MXNet (incubating) community has voted and approved
the
> > release.
> > > > > > >
> > > > > > > Vote thread:
> > > > > > >
> > > > > > >
> > > > > >
> >
> https://lists.apache.org/thread.html/4b445460d36d098be1c1e60e29869cf243e2bc37bd2b84ca7b1daab3@%3Cdev.mxnet.apache.org%3E
> > > > > > >
> > > > > > >
> > > > > > > Result thread:
> > > > > > >
> > > > > > >
> > > > > >
> >
> https://lists.apache.org/thread.html/60e3272326cf93100370fa5b01a54a4b2f18f95462553b5a1acfd456@%3Cdev.mxnet.apache.org%3E
> > > > > > >
> > > > > > > The community raised the following issues which are not
> > considered as
> > > > > > > release stopper:
> > > > > > >
> > > > > > > 1. NOTICE year is wrong (2018): Not considered a stopping
issue
> > as
> > > > > > release
> > > > > > > was started in 2018.
> > > > > > > 2. TVM NOTICE missing - TVM NOTICE file was added post
the
> > commit ID used
> > > > > > > in MXNet v1.4.0.rc2 release, not considered a stopping
issue
> > > > > > > 3. build with make passes, but build with cmake failed
in
> > > > > > > 3rdparty/dmlc-core/test/unittest
> > > > > > > 4. Recent MKLDNN upgrade prevents us from offering binary
> > distribution
> > > > > > for
> > > > > > > earlier versions before OSX 10.13.
> > > > > > >
> > > > > > >
> > > > > > > The source tarball, including signatures, digests, etc.
can be
> > found at:
> > > > > > >
> > > > > > >
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc2/
> > > > > > >
> > > > > > > The tag to be voted upon:
> > > > > > >
> https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc2
> > > > > > >
> > > > > > > The release hash is e999a46
> > > > > > > <
> > > > > >
> >
> https://github.com/apache/incubator-mxnet/commit/e999a46a8ca1383e78a9178dc65fa91e6e656c26
> > > > > > >
> > > > > > > :
> > > > > > >
> > > > > > >
> > > > > >
> >
> https://github.com/apache/incubator-mxnet/commit/e999a46a8ca1383e78a9178dc65fa91e6e656c26
> > > > > > >
> > > > > > > KEYS file available:
> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> > > > > > >
> > > > > > > For information about the contents of this release, see:
> > > > > > >
> > > > > >
> >
> https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.4.0+Release+Notes
> > > > > > >
> > > > > > > The vote will be open at least 72 hours (Sunday February
10th
> > 4pm PST)
> > > > > > and
> > > > > > > until sufficient votes are received.
> > > > > > >
> > > > > > > [ ] +1 release this package as 1.4.0
> > > > > > > [ ] +0 no opinion
> > > > > > > [ ] -1 do not release this package because...
> > > > > > >
> > > > > > > Best regards,
> > > > > > > Steffen
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Luciano Resende
> > > > > > http://twitter.com/lresende1975
> > > > > > http://lresende.blogspot.com/
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > > > For additional commands, e-mail:
> general-help@incubator.apache.org
> > > > > >
> > > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Luciano Resende
> > > > http://twitter.com/lresende1975
> > > > http://lresende.blogspot.com/
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: general-help@incubator.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message