From general-return-67079-apmail-incubator-general-archive=incubator.apache.org@incubator.apache.org Mon Jan 7 08:56:36 2019 Return-Path: X-Original-To: apmail-incubator-general-archive@www.apache.org Delivered-To: apmail-incubator-general-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0EF5E183FF for ; Mon, 7 Jan 2019 08:56:36 +0000 (UTC) Received: (qmail 29295 invoked by uid 500); 7 Jan 2019 08:56:35 -0000 Delivered-To: apmail-incubator-general-archive@incubator.apache.org Received: (qmail 28751 invoked by uid 500); 7 Jan 2019 08:56:34 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 28736 invoked by uid 99); 7 Jan 2019 08:56:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2019 08:56:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 97291C6F1E for ; Mon, 7 Jan 2019 08:56:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.155 X-Spam-Level: ** X-Spam-Status: No, score=2.155 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id F4yprBtfurQe for ; Mon, 7 Jan 2019 08:56:31 +0000 (UTC) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 55FE05FB44 for ; Mon, 7 Jan 2019 08:56:31 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id 96so42364580wrb.2 for ; Mon, 07 Jan 2019 00:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=/AtntlPj4K5Aw9SmchPmxFGQTQLhPVNHzB+DbrfqLd4=; b=oOa3pXLUhdTPY+cmoxTJ5hdogH8lvMTlbq0F+rLh/sVN6YcxwUBjNHjBFYyCqSsvpt SsWk97UrXrIWOGf4CoG+jDJFtaAUtIwVaQLHJQ0nRI+s/scoZvLxc2r3wRzI3tR/IZHz IWjh7SZG5qyvZOF6HPWfV8Uhf95lRepBTwnwqBNENsWYKC2kls1J2Z/tJ+ogmGVZkC3u FYKlHc4N1B5HBjNE9PA7uPlAA6iuu2ZHh2e9xF6lX1/WswBLHF3Yfqjs7PET8jrb31Sj QtiPLfa1QtUX/3E+KtdXqTtgSejVNKrAnEleTves8aHV8bCLW9TTUTjt04218ZaE8Xgj RD+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/AtntlPj4K5Aw9SmchPmxFGQTQLhPVNHzB+DbrfqLd4=; b=C+gumbMlwOwyu+3x8sLo68fel1ipDnBiOEQfoGPq0IM9Dh1fs4MmrW8bHEoSz1qjSn KgYQs6FSS0yq7Mvv1CR4/MDMnRIrLMHWKUXV+T3Wnt3rXr3BjhcDvL/y4cz3wjiPtSSM nEwR4rgMv/X5GeAxRmo4u2fdj+yZppEQyYnzziK5GEcbponDxACpBBoTSq7BgrIykHda 6wyXmKsseTEq0uBFXqE8SDhluaZZ8W+sqwuq1TXEfbdwDp6pCNdnpXA7a4CI4HUSQmQG qpwScpmIh8tWLBlTQtsvvfD76UaTdYDaZbi+v1r87uzppIY7nCfzfRQ22DK8Pc1uwf/3 nWFQ== X-Gm-Message-State: AJcUukd4uGSUxPYtYo6WaPMpKvPj/Iz2y3gjAQb0Ej43zwTehRAOLTqR yPH4UFlePtRaBXqGIT2XtpbunKPcHD/ghVemFMkzEXhI X-Google-Smtp-Source: ALg8bN7y9WMj0ZMIt1AetT0r384YdP0rwFaY/9sdHrG7UpedW8qCJSqIHtMcOEOEj3hrGfVft2yONsokj3cP8ZOh6RI= X-Received: by 2002:adf:bc87:: with SMTP id g7mr49178808wrh.250.1546851384507; Mon, 07 Jan 2019 00:56:24 -0800 (PST) MIME-Version: 1.0 References: <8B5EBF3F-2B86-426E-B6E9-E61F37544F74@jaguNET.com> <1C6DC662-E488-450D-AA17-86A4165538EC@classsoftware.com> In-Reply-To: From: Hagay Lupesko Date: Mon, 7 Jan 2019 00:56:13 -0800 Message-ID: Subject: Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0 To: general@incubator.apache.org Content-Type: multipart/alternative; boundary="0000000000004b430a057eda6770" --0000000000004b430a057eda6770 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Justin, Good call. I will work with my colleagues in Amazon to try and help with this. I'm not sure what is the best approach with 3P code issues though: you call out 3rdparty/onnx-tensorrt as having a mix of license types and having other issues. However, this is part of another repo, integrated into MXNet as a git submodule (https://github.com/onnx/onnx-tensorrt.git). Is it necessary to "fix" licensing of 3P packages as well? I think this will be very difficult... Curious to get your thoughts and perspective. Hagay On Sat, Jan 5, 2019 at 5:50 PM Justin Mclean wrote: > Hi, > > I=E2=80=99m still -1 (binding) there are also some LICENSE issues that ne= ed to be > looked into. > > I checked: > - incubating in name > - signature and hashes good > - DISCLAIMER exists > - LICENSE and NOTICE need some work (see below) > - No unexpected binary files > - A number of files are missing headers and it=E2=80=99s unclear how some= of these > are licensed > - I didn=E2=80=99t try to compile > > These LICENSE files mentioned in LICENSE do not exist: > - 3rdparty/tvm/dmlc-core/LICENSE > - 3rdparty/tvm/nnvm/LICENSE > - R-package/LICENSE > - nnvm/tvm/HalideIR/LICENSE > > LICENSE is missing mention of: > - ./docs/_static/js/clipboard.min.js (MIT licensed =C2=A9 Zeno Rocha) You= may > also want to include the non-minified code as that could be considered to > being =E2=80=9Ccompiled" code and could be thought of as category X. > - ./julia > - ./perl-package ? (unclear if this was developed at the ASF or not) > - 3rdparty/openmp/LICENSE.txt > - > /apache-mxnet-src-1.4.0.rc0-incubating/3rdparty/mkldnn/src/cpu/xbyak/xbya= k.h > and other .h files in that directory - note the double headers > - apache-mxnet-src-1.4.0.rc0-incubating/3rdparty/cub/test/mersenne.h > > And probably other files. It=E2=80=99s very hard to review when the copyr= ight > owners are not clearly indicated in LICENSE. It would help if all license > file were placed in one directory, that way it would be easy to search if > all required licenses have been included. > > I think a lot more work is needed on the LICENSE here for instance taking > a look at one directory: > 3rdparty/onnx-tensorrt > > With the LICENSE file containing: > MIT License > Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > Copyright (c) 2018 Open Neural Network Exchange > > However searching for license and copyright under that you can see it > contains a mix of different licensed files, including MIT, BSD, Apache an= d > at least 30 different copyright statements. I can see some of the > sub-directory are also referenced but it doesn=E2=80=99t seem complete to= me. > > There are lots of other files missing headers, in some cases it could be > assumed that they are 3rd party files, but in some cases it is unclear. F= or > instance: > > File in ./docs/_static/js/*.,js are missing headers. How are theses > licensed? > > This files are missing headers - how are they licensed? > ./src/operator/special_functions-inl.h > ./src/operator/contrib/nn/deformable_im2col.cuh > ./src/operator/contrib/nn/deformable_im2col.h > ./src/operator/nn/im2col.cuh > ./src/operator/nn/im2col.h > ./src/operator/nn/pool.h > > It might help you if you used a tool like https://www.fossology.org to > track everything a you have a large number of 3rd party licensed software > from a large number of authors. > > Thanks, > Justin > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > For additional commands, e-mail: general-help@incubator.apache.org > > --0000000000004b430a057eda6770--