incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache NetBeans 10.0 (incubating) [vote candidate 3]
Date Wed, 21 Nov 2018 06:30:59 GMT
Hi,

-1 (binding)

I’ve not checked everything yet on this release but I as it contains compiled code I can’t
vote +1.

I don’t think these are OK except perhaps the first one:

./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/empty.jar
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed-twice.jar
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed.jar

And these are certainly not:
./platform/libs.junit4/external/junit-4.12.jar
./platform/libs.junit4/external/hamcrest-core-1.3.jar
./platform/netbinox/external/org.eclipse.osgi_3.9.1.v20140110-1610.jar
./platform/libs.osgi/external/osgi.cmpn-4.2.jar
./platform/javahelp/external/jhall-2.0_05.jar

I notice a number of text files (mostly standards) under CDDL and EPL licenses, These are
Category B and are not normally allowed in a source release. Has this been discussed somewhere?

I also notice some source files without ASF headers, for instance [1][2][3] and others

Thanks,
Justin

1. /java/java.editor/test/qa-functional/data/projects/Formatting/src/general/BlankLines.java
2. /ide/diff/test/unit/data/patch/testFileCopyRename/NewClass.java
3. java/java.editor/test/qa-functional/data/projects/Formatting/src/general/ReduceBlankLines.java


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message