incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jun Liu <liu...@apache.org>
Subject Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]
Date Mon, 20 Aug 2018 03:27:44 GMT
> I guess you did use the maven release plugin to do the latest release, as
> we cannot see the release plugin commit  log there.

Yes, we used maven release plugin to do the latest release, and it has automatically changed
the version to ‘2.6.4-SNAPSHOT’. I forgot to change it back when tag in this round.

> As we are doing the source release, it quit import that we ship the exactly
> source which is tagged to let the other user can do the same release
> without changing the code.

Agree, I think we should start a new round of vote to address this issue.

Best regards,
Jun

> On 18 Aug 2018, at 17:33, Willem Jiang <willem.jiang@gmail.com> wrote:
> 
> I checked the source.zip file data, it is same with the data with the tag,
> but the pom version was not same with the git repo as Mark already point
> out.
> I guess you did use the maven release plugin to do the latest release, as
> we cannot see the release plugin commit  log there.
> 
> After going through PPMC voting thread, there are several rounds of vote
> there, so I guess there may have some uncommitted change when doing the
> release.
> As we are doing the source release, it quit import that we ship the exactly
> source which is tagged to let the other user can do the same release
> without changing the code.
> 
> @Jun Liu,  could you double check that?
> 
> 
> Willem Jiang
> 
> Twitter: willemjiang
> Weibo: 姜宁willem
> 
> On Sat, Aug 18, 2018 at 5:56 AM, Mark Thomas <markt@apache.org> wrote:
> 
>> On 12/08/18 08:12, Jun Liu wrote:
>> 
>> <snip/>
>> 
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [X] -1 disapprove with the reason (binding)
>> 
>> The sha512 hashes are missing the '*' marker that indicates they are
>> hashes for binary files rather than text files. Trivial issue. Can be
>> addressed in the next release.
>> 
>> I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
>> to have (not all Apache projects use this naming convention). Something
>> to consider for the next release.
>> 
>> Consider including mvnw and mvnw.cmd in the source release so it is
>> simpler to get started with the build from a source release.
>> 
>> The 2.6.3 tag does not agree with the source release. This is a
>> significant issue and enough for me to vote against the release. A diff
>> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
>> the tag but "2.6.3" in the source release.
>> 
>> I dug into this a little. At first I thought the tag / commit in the
>> vote was wrong. It is. But is isn't just that. If I go back to
>> 
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> things are better but:
>> a) there are still differences
>> b) the tag includes multiple commits after this point
>> 
>> 
>> Mark
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message