incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent S Hou" <s...@us.ibm.com>
Subject Re: [VOTE]: Release Apache OpenWhisk (Incubating): main module 0.9.0 [RC2]
Date Sun, 15 Jul 2018 17:34:39 GMT
Hi Matt,

We do not want ship any jar file inside the source code artifact, so gradle-wrapper.jar has
been removed from the package.
However, you can follow the instruction here: https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.9.0-incubating-rc2/doc/INSTALL.md,
to add the jar back, with the command: gradle wrapper.

Best wishes.
Vincent Hou (侯胜博)

Advisory Software Engineer, OpenWhisk Contributor, Open Technology, IBM Cloud

Notes ID: Vincent S Hou/Raleigh/IBM, E-mail: shou@us.ibm.com,
Phone: +1(919)254-7182
Address: 4205 S Miami Blvd (Cornwallis Drive), Durham, NC 27703, United States

-----Matt Sicker <boards@gmail.com> wrote: -----
To: general@incubator.apache.org
From: Matt Sicker <boards@gmail.com>
Date: 07/15/2018 12:30PM
Subject: Re: [VOTE]: Release Apache OpenWhisk (Incubating): main module 0.9.0 [RC2]

+1 (binding)

- signature ok
- incubating in name
- disclaimer file
- notice and license (other than the line mentioned by Justin already)
- included gradle wrapper in source tar does not work (seems to be missing
the bootstrap jar)
- nonetheless, builds fine with my system copy of gradle 4.8.1

Justin: that ConcurrentMapBackedCache.scala file is mentioned in
LICENSE.txt as a 3rd party file.

On Sat, 14 Jul 2018 at 02:01, Justin Mclean <justinmclean@me.com> wrote:

> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in name
> - signature and hashes fine
> - DISCLAIMER exists
> - LICENSE incorrectly has a filled in copyright line in the appendix
> please fix
> - NOTICE fine
> - No unexpected binary file
> - A few files are missing ASF headers (e.g. .sh files) and not sure this
> file should have an ASF header [1]
> - Can compile from source
>
> Thanks,
> Justin
>
>
> 1.
> incubator-openwhisk-0.9.0-incubating/common/scala/src/main/scala/whisk/core/database/ConcurrentMapBackedCache.scala
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

-- 
Matt Sicker <boards@gmail.com>


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message