incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SHUANG SU <sushuang0...@gmail.com>
Subject Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Date Fri, 01 Jun 2018 08:50:11 GMT
------------------------------
 Su Shuang (100pah)
------------------------------


2018-06-01 1:07 GMT+08:00 Dave Fisher <dave2wave@comcast.net>:

> Hi -
>
> I’m VOTING +0.
>
> (1) I am rather confused by this D3 license. For example:
>
> src/chart/tree/layoutHelper.js
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements.  See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership.  The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License.  You may obtain a copy of the License at
> *
> *   http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing,
> * software distributed under the License is distributed on an
> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> * KIND, either express or implied.  See the License for the
> * specific language governing permissions and limitations
> * under the License.
> */
>
> /*
> * The tree layout implementation references to d3.js
> * (https://github.com/d3/d3-hierarchy). The use of the source
> * code of this file is also subject to the terms and consitions
> * of its license (BSD-3Clause, see <echarts/src/licenses/LICENSE-d3>).
> */
>
> /**
>  * @file The layout algorithm of node-link tree diagrams. Here we using
> Reingold-Tilford algorithm to drawing
>  *       the tree.
>  * @see https://github.com/d3/d3-hierarchy
>  */
>
> import * as layout from '../../util/layout';
> ...
>
> Without deep analysis I have no idea what parts are D3. If this whole file
> is based on D3 then in my opinion this whole source file needs to be BSD-3
> clause licensed.
>
> I would change my VOTE to +1 if there is a good explanation.
>
>

Hi Dave,

Most of the logic in `src/chart/tree/layoutHelper.js` is based on
https://github.com/d3/d3-hierarchy/blob/44ba491e8c6d5b8af21280f6507d4d
372bc4272d/src/tree.js

But, basically the file is a collection of layout utils for the tree
component, in which some other logic
not relative to d3 also exists, and may be added more in futher. So I think
it is still a file that under the
Apache license as other files of this project, and including some code with
d3 BSD license embeded.


Thanks.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message