incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Date Mon, 21 May 2018 17:06:52 GMT
On 21 May 2018 at 08:59, Justin Mclean <justin@classsoftware.com> wrote:
> Hi,
>
>> As I cannot build the binary without doing some changes on the pom file, I
>> had to vote -1 (binding) here.
>
> You don’t need to modify the pom file to compile you can specify -Dcheckstyle.skip
to compile id check style is acting up for you.
>
> Up to you if you want to vote -1 but I just want to remind people here (mostly the Dubbo
PMC who are new to this) that:
> - a -1 vote is not a veto (but should be carefully considered)
> - a release only need 3 +1 votes and more +1 than -1 to pass
> - you can vote +0 or change you vote if you think the issue can be fixed next release
>
>> 2. I checked the source zip[1], it is not same with github tag one[2].
>> There are some log files and empty directories which is not in the git
>> repo, I guess it relates to the builder's workspace.
>
> Which is OK many project release are not 100% identical to what is in the release tar
what is important is that none of the source code has changed.

Huh?

I don't think there should be anything in the source release that is
not in the source repo.

> Thanks,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message