incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3
Date Mon, 14 May 2018 02:49:49 GMT
On 13 May 2018 at 12:10, Matteo Merli <mmerli@apache.org> wrote:

> The code in question is testing a feature that takes Jars from a user and
> execute the code contained. Indeed the Jar should not be in the sources,
> though I believe the test is correct here: we need to validate the specific
> feature by dynamically loading a Jar.
>

By generating the binary jar from source files at test time, you'd avoid
bundling any binary output files.


> > (e.g., injecting a
> module-info.class file at build time rather than requiring Java 9+ to build
> regardless).
>
> I don't see any place in the code where we are using "module-info.class"
> and the project requires Java 8 and not 9.
>

Sorry for the confusion, that was just an example from a problem I've seen
before in another project.

-- 
Matt Sicker <boards@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message