incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 5
Date Sat, 26 May 2018 01:39:24 GMT
Hi,

+1 (binding)

I checked:
- incubating in name
- DISCLAIMER exists
- LICENSE is OK and NOTICE good
- All source files have ASF headers
- No unexpected binary files
- Can compile from source

Minor issue is that LICENSE is missing mention of these files [1][2][3] (but includes their
license), be nice to fix that for the net release.

Thanks,
Justin

1. ./pulsar-client-cpp/lib/checksum/int_types.h
2. ./pulsar-client-cpp/lib/checksum/crc32c_sse42.h
3. ./pulsar-client-cpp/lib/checksum/crc32c_sse42.cc
4. ./pulsar-client-cpp/lib/checksum/gf2.hpp
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message