Hi Justin,
I mentioned this in my vote:
"* We can do a minor improvement on the NOTICE formating"
The content looks OK to me, but not in the right place/formating. I didn't
consider this as blocker (as it's there, even if not super accurate) and we can
fix in the next cycle, but I got your point.
Regards
JB
On 03/02/2018 09:26 AM, Justin Mclean wrote:
> Hi,
>
> -1 (binding) as there is incorrect and far too much information in NOTICE. License information
goes in LICENSE not NOTICE. [1] Also only things that are actually bundled need to be mentioned
not dependancies. [2]
>
> BTW it's not entirely clear which of the releases artefacts are source release and what
aren’t without carefully looking at them.
>
> I checked:
> - signatures and hash correct
> - disclaimer exists
> - LICENSE is missing things
> - NOTICE is not correct
> - no unexpected binaries
> - source code have ASF headers
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> 2. http://www.apache.org/dev/licensing-howto.html#guiding-principle
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
|