incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Makoto Yui <m...@apache.org>
Subject Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2
Date Tue, 06 Feb 2018 06:49:17 GMT
Hi Justin,

I'm revising LICENSE and NOTICE files following your comments and [D].

https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L205
(copyrights are removed from LICENSE)
https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE

Does it seem okey for you?

[D] says 'Copyright notifications which have been relocated from
source files (rather than removed) must be preserved in NOTICE.'.

> For instance this file [3] has incorrectly both an ASF header and another Apache license
header and is mentioned as a file who’s header has been relocated in NOTICE. IMO just keep
the file’s original header, don’t add an Apache one and there is no need to put anything
in NOTICE.

I'm wondering how to fix the license headers of modified codes.

Just writing the original header is not enough because it has
additional/modified codes (e.g., when only a method is reused from
original file).
I think then both original copyright and copyright by our ASF project
should be listed.

Specifically,

> File have ASF header but there’s some files that header have been added where IMO they
should not of been [8][9]

[8][9] is an aggressively modified version of original code and thus
having both the original header and ASF header is expected.
Both our copyright and the original copyright should be kept.
Duplicate entries of ASF license can be eliminated though.

I'm consider to use LicenseHeader1.java format of [B]
(LicenseHeader2.java format of [B] is invalid in RAT check).

> this BSD licensed file [7] which also incorrectly has an ASF header

It's a modified version (encoding/decoding table is changed) of [A]
and thus having both the original header and ASF header is expected.

Having both header for modified code seems to be existing in various
TLP projects (e.g., [C]), passing legal checks.

Thanks,
Makoto

[7] hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/codec/Base91.java
[8] hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
[9] hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/regression/RegressionTree.java
[A] https://github.com/bwaldvogel/base91/blob/670c254f90c9f588e4590bbf6765ac07e996492b/src/main/java/de/bwaldvogel/base91/Base91.java
[B] https://gist.github.com/myui/20f1d18253b5cfc018c06429eb07bc57
[C] https://github.com/apache/hadoop/blob/f67237cbe7bc48a1b9088e990800b37529f1db2a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/bloom/HashFunction.java
[D] http://www.apache.org/dev/licensing-howto.html#mod-notice

2018-01-30 8:57 GMT+09:00 Justin Mclean <justin@classsoftware.com>:
> Hi,
>
> Sorry it -1 from me as there is compiled code in the sure release. [1]
>
> I checked:
> - incubating in name
> - signatures and hashes fine
> - DISCLAIMER exists
> - LICENSE is missing several things including the licence appendix and licenses of included
software [2]
> - NOTICE has some issues
> - File have ASF header but there’s some files that header have been added where IMO
they should not of been [8][9]
> - unexpended binary in source release [1]
> - could compile core
>
> Including instructions on how to build from source in the release would be useful.
>
> The source software bundles several bits of software from other projects and these need
to be mentioned in LICENSE. Please ask for help from your mentors in fixing this and read
this [2]. From what I can see LICENSE is missing:
> - MIT and OFL license font awesome [4][5]
> - public domain code included in this file [6]
> - this BSD licensed file [7] which also incorrectly has an ASF header
> - you may or may not want to list other ALv2 pieces of software as well
>
> For the NOTICE the information about relocated copyrights IMO is not correct and should
be removed as you want to keep NOTICE files as small as possible. Relocated copyright are
usually those relocated to NOTICE as part of a software grant. For instance this file [3]
has incorrectly both an ASF header and another Apache license  header and is mentioned as
a file who’s header has been relocated in NOTICE. IMO just keep the file’s original header,
don’t add an Apache one and there is no need to put anything in NOTICE.
>
> Also please put the actual year not "Copyright 2016 and onwards” in the NOTICE file.
>
> Thanks,
> Justin
>
> 1. hivemall-0.5.0-incubating-rc2/xgboost/lib/xgboost4j-0.7.jar
> 2. http://www.apache.org/dev/licensing-howto.html
> 3. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
> 4. hivemall-0.5.0-incubating-rc2/src/site/resources/css/font-awesome.css
> 5. hivemall-0.5.0-incubating-rc2/src/site/resources/fonts/fontawesome-webfont/*
> 6. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/math/FastMath.java
> 7. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/codec/Base91.java
> 8. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
> 9. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/regression/RegressionTree.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>



-- 
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message