incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John D. Ament" <johndam...@apache.org>
Subject Re: License headers on test data (was Re: [VOTE] Release Apache NetBeans 9.0 Beta (incubating) rc2)
Date Mon, 22 Jan 2018 14:15:42 GMT
On Mon, Jan 22, 2018 at 8:03 AM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:

> On Monday, January 22, 2018, John D. Ament <johndament@apache.org> wrote:
>
> > >
> > >
> > > > - Specific call outs in the README about test data licensing not be
> > > Apache
> > > > license
> > > >
> > >
> > > This is one of the things that are very unclear to me. If we are
> talking
> > > about files like these [1][2][3][4][5][6] (they may appear to differ,
> but
> > > they actually are all the same: test data), then I believe these were
> > part
> > > of the initial donation and I don't have a reason to believe these are
> > not
> > > under the Apache license. Of course we could list them in the README,
> but
> > > if that's a requirement, I'd suggest to fix:
> > > https://www.apache.org/legal/src-headers.html#faq-exceptions
> > >
> > > to include that requirement to avoid further confusion.
> > >
> > >
> > I've seen you post this link several times now in this thread.  I
> > personally have no idea what you'd like to get updated on this page, and
> > the IPMC cannot help you get that updated, only the legal committee can.
> >
> > I'm assuming that some of your concerns are around bullet #2 "Test data
> for
> > which the addition of a source header would cause the tests to fail."
>
>
> Snip snip...
>
>
> >
> > Or am I miss understanding your points around changing this document?
>
>
>
> It’s not about that document (which simply needs to be relicensed to Apache
> like all other files from the donation, simply slipped through that process
> somehow) but about those in Jan’s mail, i.e., the test data and pseudo code
> in test/*/data folders.
>
>
As best as I can tell, only the file I mentioned and its pair
(DiffTestFile1b.txt) are the ones with the wrong license on them.  The
other files were not raised by Justin as having bad headers, since we have
already documented that test data does not require the headers for the
reasons listed on that page.

A similar problem exists with the file "testMoveClass.pass" which ends up
including multiple license headers.  I'm actually OK with that file, since
its clear that its trying to test these scenarios.

John


> Gj
>
>
>
> >
> >
> > >
> > > > - Specific call outs somewhere that the XSDs, ENTs, etc are derived
> > from
> > > > other locations
> > > >
> > >
> > > I've sent an e-mail to dev@netbeans asking those to be resolved.
> > >
> > > Thanks,
> > >    Jan
> > >
> > > [1]
> > >
> > > https://github.com/apache/incubator-netbeans/blob/
> > master/java.hints/test/unit/data/org/netbeans/test/java/
> > hints/AddCast1.java
> > > [2]
> > >
> > > https://github.com/apache/incubator-netbeans/blob/
> > master/java.hints/test/unit/data/goldenfiles/org/netbeans/
> > modules/java/hints/errors/ErrorHintsTest/testAddCastHint1-hints.pass
> > > [3]
> > >
> > > https://github.com/apache/incubator-netbeans/blob/
> > master/java.hints/test/unit/data/goldenfiles/org/netbeans/
> > modules/java/hints/errors/ErrorHintsTest/testAddCastHint1.pass
> > > [4]
> > >
> > > https://github.com/apache/incubator-netbeans/blob/
> > master/java.completion/test/unit/data/goldenfiles/org/
> > netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/
> > intVarName.pass
> > > [5]
> > >
> > > https://github.com/apache/incubator-netbeans/blob/
> > master/java.completion/test/unit/data/goldenfiles/org/
> > netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/empty.pass
> > > [6]
> > >
> > > https://github.com/apache/incubator-netbeans/blob/
> > master/java.completion/test/unit/data/goldenfiles/org/
> > netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/
> > CreateConstructorNonDefaultConstructor.pass
> > >
> > >
> > > > >
> > > > > Gj
> > > > >
> > > > > On Monday, January 22, 2018, Justin Mclean <
> justin@classsoftware.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > > I am not sure what the point is of spending time on putting
rat
> > > > > > exclusions
> > > > > > > together if they’re simply going to be ignored when it
comes to
> > > IPMC
> > > > > > > members evaluating a release.
> > > > > >
> > > > > > Rat exclusions are fine if they comply with policy and don’t
hide
> > > > things.
> > > > > > I’ve reviewed and voted on 300+ releases on the IPMC list
so
> > perhaps
> > > I
> > > > > have
> > > > > > some advice to give that you should listen to. You can of course
> > > choose
> > > > > to
> > > > > > ignore it.
> > > > > >
> > > > > > > Yes, we can of course discuss those rat exclusions. No,
they
> > cannot
> > > > > > simply be ignored and we cannot be confronted
> > > > > > > with a very long list of issues in the IPMC vote thread
> primarily
> > > > based
> > > > > > on
> > > > > > > the fact that our rat exclusions have been ignored.
> > > > > >
> > > > > > Some of the issues I’ve brought up are minor and can be fixed
in
> > > later
> > > > > > releases and some IMO are not and are not in line with ASF
> > licensing
> > > or
> > > > > > release policy. I suggest you try are fix those.
> > > > > >
> > > > > > > I would like this to be affirmed by the IPMC and I would
like
> our
> > > > > > mentors to advise on their perspective on this too.
> > > > > >
> > > > > > That would be a good way forward. As I said said previously
your
> > > > mentors
> > > > > > can vote +1 on this release - my vote is not a veto. I would
be
> > > totally
> > > > > > fine if you got  3 +1 votes from other IPMC members and my vote
> is
> > > the
> > > > > only
> > > > > > -1.That’s how Apache works.
> > > > > >
> > > > > > Thanks,
> > > > > > Justin
> > > > > > ------------------------------------------------------------
> > ---------
> > > > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > > > For additional commands, e-mail:
> general-help@incubator.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message